Re: [Qemu-devel] [PATCH v3 1/5] qga: win32: fix crashes when PCI info cannot be retrived

2018-10-01 Thread Tomáš Golembiovský
On Thu, 27 Sep 2018 18:16:04 +0300 Sameeh Jubran wrote: > On Thu, Sep 27, 2018 at 12:06 PM Tomáš Golembiovský > wrote: > > > Hi Michael, > > > > thanks for looking into this. My comments are below. > > > > Adding Sameeh... > > > > > > On Wed, 26 Sep 2018 12:15:48 -0500 > > Michael Roth wrote:

Re: [Qemu-devel] [PATCH v3 1/5] qga: win32: fix crashes when PCI info cannot be retrived

2018-09-27 Thread Sameeh Jubran
On Thu, Sep 27, 2018 at 12:06 PM Tomáš Golembiovský wrote: > Hi Michael, > > thanks for looking into this. My comments are below. > > Adding Sameeh... > > > On Wed, 26 Sep 2018 12:15:48 -0500 > Michael Roth wrote: > > > Quoting Tomáš Golembiovský (2018-09-07 06:42:09) > > > The guest-get-fsinfo

Re: [Qemu-devel] [PATCH v3 1/5] qga: win32: fix crashes when PCI info cannot be retrived

2018-09-27 Thread Tomáš Golembiovský
Hi Michael, thanks for looking into this. My comments are below. Adding Sameeh... On Wed, 26 Sep 2018 12:15:48 -0500 Michael Roth wrote: > Quoting Tomáš Golembiovský (2018-09-07 06:42:09) > > The guest-get-fsinfo command collects also information about PCI > > controller where the disk is

Re: [Qemu-devel] [PATCH v3 1/5] qga: win32: fix crashes when PCI info cannot be retrived

2018-09-26 Thread Michael Roth
Quoting Tomáš Golembiovský (2018-09-07 06:42:09) > The guest-get-fsinfo command collects also information about PCI > controller where the disk is attached. When this fails for some reasons > it tries to return just the partial information. However in certain > cases the pointer to the structure

[Qemu-devel] [PATCH v3 1/5] qga: win32: fix crashes when PCI info cannot be retrived

2018-09-07 Thread Tomáš Golembiovský
The guest-get-fsinfo command collects also information about PCI controller where the disk is attached. When this fails for some reasons it tries to return just the partial information. However in certain cases the pointer to the structure was not initialized and was set to NULL. This breaks the