Re: [Qemu-devel] [PATCH v3 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

2019-03-01 Thread Peter Maydell
On Thu, 28 Feb 2019 at 21:53, G 3 wrote: > On Mon, Feb 25, 2019 at 5:24 AM Peter Maydell > wrote: >> +// Utility function to run specified code block with iothread lock held >> +typedef void (^CodeBlock)(void); > > > Please don't use blocks. It would lock Mac OS X users into having to use > CLa

Re: [Qemu-devel] [PATCH v3 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

2019-02-28 Thread G 3
On Mon, Feb 25, 2019 at 5:24 AM Peter Maydell wrote: > The Cocoa UI should run on the main thread; this is enforced > in OSX Mojave. In order to be able to run on the main thread, > we need to make sure we hold the iothread lock whenever we > call into various QEMU UI midlayer functions. > > Sign

[Qemu-devel] [PATCH v3 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

2019-02-25 Thread Peter Maydell
The Cocoa UI should run on the main thread; this is enforced in OSX Mojave. In order to be able to run on the main thread, we need to make sure we hold the iothread lock whenever we call into various QEMU UI midlayer functions. Signed-off-by: Peter Maydell Reviewed-by: Roman Bolshakov Tested-by: