Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-16 Thread Stefan Hajnoczi
On Wed, May 15, 2013 at 04:42:57PM +0200, Paolo Bonzini wrote: Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time

[Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Stefan Hajnoczi
The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before overwriting it. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before overwriting it.

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Wenchao Xia
Reviewed the code, except Paolo's comments, function seems fine. Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time