Re: [Qemu-devel] [PATCH v3 1/9] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-14 Thread David Gibson
On Thu, Jun 14, 2018 at 10:18:33AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > > > Signed-off-by: BALATON Zoltan > > > > But.. they are implemented. Albeit as an entirely software controlled > > reg

Re: [Qemu-devel] [PATCH v3 1/9] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan But.. they are implemented. Albeit as an entirely software controlled register. They were implemented only in that they could be written and read but did

Re: [Qemu-devel] [PATCH v3 1/9] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-13 Thread David Gibson
On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan But.. they are implemented. Albeit as an entirely software controlled register. I'm guessing that's not what they're supposed to do, which is why you're removing them, but that needs to be explained

[Qemu-devel] [PATCH v3 1/9] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-13 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/i2c/ppc4xx_i2c.c | 16 +--- include/hw/i2c/ppc4xx_i2c.h | 4 +--- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/hw/i2c/ppc4xx_i2c.c b/hw/i2c/ppc4xx_i2c.c index d1936db..4e0aaae 100644 --- a/hw/i2c/ppc4xx_i2c.c +++ b/hw/i2