Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 14:54, Kevin Wolf ha scritto: >> > +proto_drv = bdrv_find_protocol(target); >> > +if (!proto_drv) { >> > +error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); > This error message is still not fixed, and totally confusing, pointing > at the wrong cause. No matter what c

Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 16:49, schrieb Paolo Bonzini: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > v2->v3: bdrv_is_inserted pulled before dereference of bs->drv > > blockdev.c | 124 > +++

Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-18 Thread Eric Blake
On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > +# > +# @format: #optional the format of the new destination, default is to > +# probe is @mode is 'existing', e

[Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-18 Thread Paolo Bonzini
This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini --- v2->v3: bdrv_is_inserted pulled before dereference of bs->drv blockdev.c | 124 +++ hmp-commands.hx | 21 ++ hmp.c