Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> The patch is big, but all it really does is replacing
>
> dinfo->bdrv
>
> by
>
> blk_bs(blk_by_legacy_dinfo(dinfo))
>
> The replacement is repetitive, but the conversion of device models to
> BlockBackend is imminent, and will
On 16.09.2014 20:12, Markus Armbruster wrote:
The patch is big, but all it really does is replacing
dinfo->bdrv
by
blk_bs(blk_by_legacy_dinfo(dinfo))
The replacement is repetitive, but the conversion of device models to
BlockBackend is imminent, and will shorten it to just
blk_legac
Benoît Canet writes:
> On Tue, Sep 16, 2014 at 08:12:15PM +0200, Markus Armbruster wrote:
Restoring context...
@@ -252,14 +253,16 @@ static int milkymist_memcard_init(SysBusDevice *dev)
{
MilkymistMemcardState *s = MILKYMIST_MEMCARD(dev);
DriveInfo *dinfo;
+BlockDr
On Tue, Sep 16, 2014 at 08:12:15PM +0200, Markus Armbruster wrote:
> -s->enabled = dinfo ? bdrv_is_inserted(dinfo->bdrv) : 0;
> +s->enabled = bs && bdrv_is_inserted(bs);
This is not so mechanical but seems correct anyway.
Reviewed-by: Benoit Canet
The patch is big, but all it really does is replacing
dinfo->bdrv
by
blk_bs(blk_by_legacy_dinfo(dinfo))
The replacement is repetitive, but the conversion of device models to
BlockBackend is imminent, and will shorten it to just
blk_legacy_dinfo(dinfo).
Line wrapping muddies the waters
