[Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-22 Thread Paolo Bonzini
The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/bl

Re: [Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2

Re: [Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:34, Peter Lieven ha scritto: >> @@ -1012,6 +1018,14 @@ retry: >> } >> if (iTask.status != SCSI_STATUS_GOOD) { >> +if (iTask.status == SCSI_STATUS_CHECK_CONDITION && >> +iTask.task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST && >> +iTask.