Re: [Qemu-devel] [PATCH v3 13/13] pc-dimm: get_memory_region() will not fail after realize

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 04:04:48PM +0200, David Hildenbrand wrote: > Let's try to reduce error handling a bit. In the plug/unplug case, the > device was realized and therefore we can assume that getting access to > the memory region will not fail. > > For get_vmstate_memory_region() this is alread

[Qemu-devel] [PATCH v3 13/13] pc-dimm: get_memory_region() will not fail after realize

2018-06-15 Thread David Hildenbrand
Let's try to reduce error handling a bit. In the plug/unplug case, the device was realized and therefore we can assume that getting access to the memory region will not fail. For get_vmstate_memory_region() this is already handled that way. Document both cases. Reviewed-by: Igor Mammedov Signed-