Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-27 Thread Nikunj A Dadhania
Alex Bennée writes: > Nikunj A Dadhania writes: > >> Richard Henderson writes: >> >>> On 09/12/2016 06:47 AM, Alex Bennée wrote: > > +/* Notice an IO access, or a notdirty page. */ > > +if (unlikely(tlb_addr

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Nikunj A Dadhania
Alex Bennée writes: > Nikunj A Dadhania writes: > >> Richard Henderson writes: >> >>> On 09/12/2016 06:47 AM, Alex Bennée wrote: > > +/* Notice an IO access, or a notdirty page. */ > > +if (unlikely(tlb_addr

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Alex Bennée
Nikunj A Dadhania writes: > Richard Henderson writes: > >> On 09/12/2016 06:47 AM, Alex Bennée wrote: > +/* Notice an IO access, or a notdirty page. */ > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { > +/* There's

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Nikunj A Dadhania
Richard Henderson writes: > On 09/12/2016 06:47 AM, Alex Bennée wrote: >>> > +/* Notice an IO access, or a notdirty page. */ >>> > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { >>> > +/* There's really nothing that can be done to >>> > + support this

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Alex Bennée
Richard Henderson writes: > On 09/13/2016 10:06 AM, Alex Bennée wrote: >> I get a failure when building on centos6, x86: >> >> CCaarch64-softmmu/tcg/tcg-op.o >> /home/alex/lsrc/qemu.git/tcg/tcg-op.c:2280: error: >> ‘gen_helper_atomic_fetch_addb’ undeclared here (not in

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Richard Henderson
On 09/12/2016 06:47 AM, Alex Bennée wrote: >> > +/* Notice an IO access, or a notdirty page. */ >> > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { >> > +/* There's really nothing that can be done to >> > + support this apart from stop-the-world. */ >> > +goto

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Richard Henderson
On 09/13/2016 10:06 AM, Alex Bennée wrote: > I get a failure when building on centos6, x86: > > CCaarch64-softmmu/tcg/tcg-op.o > /home/alex/lsrc/qemu.git/tcg/tcg-op.c:2280: error: > ‘gen_helper_atomic_fetch_addb’ undeclared here (not in a function) >

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson > --- > Makefile.objs | 1

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Leon Alrae
On Mon, Sep 12, 2016 at 09:13:10AM -0700, Richard Henderson wrote: > On 09/12/2016 12:59 AM, Leon Alrae wrote: > >On Fri, Sep 09, 2016 at 09:26:29AM -0700, Richard Henderson wrote: > >>On 09/09/2016 07:46 AM, Leon Alrae wrote: > >>>Wouldn't it be useful if tcg.h provided also aliases for _le/_be

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-12 Thread Richard Henderson
On 09/12/2016 12:59 AM, Leon Alrae wrote: On Fri, Sep 09, 2016 at 09:26:29AM -0700, Richard Henderson wrote: On 09/09/2016 07:46 AM, Leon Alrae wrote: Wouldn't it be useful if tcg.h provided also aliases for _le/_be atomic helpers (equivalent to helper_ret_X_mmu) so that in target-* code we

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-12 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson > > +/* Probe for a

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-12 Thread Leon Alrae
On Fri, Sep 09, 2016 at 09:26:29AM -0700, Richard Henderson wrote: > On 09/09/2016 07:46 AM, Leon Alrae wrote: > >Wouldn't it be useful if tcg.h provided also aliases for _le/_be atomic > >helpers (equivalent to helper_ret_X_mmu) so that in target-* code we wouldn't > >need to care about the

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-09 Thread Richard Henderson
On 09/09/2016 07:46 AM, Leon Alrae wrote: Wouldn't it be useful if tcg.h provided also aliases for _le/_be atomic helpers (equivalent to helper_ret_X_mmu) so that in target-* code we wouldn't need to care about the endianness (specifically I'm thinking about SC in MIPS where I need to select

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-09 Thread Leon Alrae
On Sat, Sep 03, 2016 at 09:39:41PM +0100, Richard Henderson wrote: > --- a/tcg/tcg.h > +++ b/tcg/tcg.h > @@ -1175,6 +1175,59 @@ uint64_t helper_be_ldq_cmmu(CPUArchState *env, > target_ulong addr, > # define helper_ret_ldq_cmmu helper_le_ldq_cmmu > #endif > > +uint32_t

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-09 Thread Leon Alrae
> +#define GEN_ATOMIC_HELPER(NAME, OP, NEW)\ > +static void * const table_##NAME[16] = {\ > +[MO_8] = gen_helper_atomic_##NAME##b, \ > +[MO_16 | MO_LE] = gen_helper_atomic_##NAME##w_le,

[Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-03 Thread Richard Henderson
Add all of cmpxchg, op_fetch, fetch_op, and xchg. Handle both endian-ness, and sizes up to 8. Handle expanding non-atomically, when emulating in serial. Signed-off-by: Richard Henderson --- Makefile.objs | 1 - Makefile.target | 1 + atomic_template.h |