Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-14 Thread Igor Mammedov
On Mon, 13 Jul 2015 16:55:29 -0500 Corey Minyard wrote: > On 07/09/2015 03:25 AM, Igor Mammedov wrote: > > On Wed, 8 Jul 2015 22:39:24 +0200 > > Paolo Bonzini wrote: > > > >> > >> On 08/07/2015 21:26, Igor Mammedov wrote: > This was suggested by Michael, so I think you should read the revie

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-13 Thread Corey Minyard
On 07/09/2015 03:25 AM, Igor Mammedov wrote: > On Wed, 8 Jul 2015 22:39:24 +0200 > Paolo Bonzini wrote: > >> >> On 08/07/2015 21:26, Igor Mammedov wrote: This was suggested by Michael, so I think you should read the reviews of earlier versions first. >>> That is basically the same as hoo

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-09 Thread Igor Mammedov
On Wed, 8 Jul 2015 22:39:24 +0200 Paolo Bonzini wrote: > > > On 08/07/2015 21:26, Igor Mammedov wrote: > > > This was suggested by Michael, so I think you should read the reviews > > > of earlier versions first. > > > > That is basically the same as hooks in v1 only the other way around > > wi

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 21:26, Igor Mammedov wrote: > > This was suggested by Michael, so I think you should read the reviews > > of earlier versions first. > > That is basically the same as hooks in v1 only the other way around > with all drawbacks attached. > > Just dropping this universal way to scatt

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-08 Thread Igor Mammedov
On Wed, 8 Jul 2015 19:44:16 +0200 Paolo Bonzini wrote: > > > On 07/07/2015 10:08, Igor Mammedov wrote: > > > Some devices, like IPMI, need to add ACPI table entries to report > > > their presence. Add a method for adding these entries. > > > > I think that it's not up to device to define in wh

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-08 Thread Paolo Bonzini
On 07/07/2015 10:08, Igor Mammedov wrote: > > Some devices, like IPMI, need to add ACPI table entries to report > > their presence. Add a method for adding these entries. > > I think that it's not up to device to define in which table/scope > it's entries should be but rather upto a board/platfo

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-07 Thread Igor Mammedov
On Mon, 8 Jun 2015 20:12:09 -0500 miny...@acm.org wrote: > From: Corey Minyard > > Some devices, like IPMI, need to add ACPI table entries to report > their presence. Add a method for adding these entries. I think that it's not up to device to define in which table/scope it's entries should be

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-03 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 08:12:09PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Some devices, like IPMI, need to add ACPI table entries to report > their presence. Add a method for adding these entries. > > Signed-off-by: Corey Minyard > --- > hw/acpi/Makefile.objs | 1

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-03 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 08:12:09PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Some devices, like IPMI, need to add ACPI table entries to report > their presence. Add a method for adding these entries. > > Signed-off-by: Corey Minyard > --- > hw/acpi/Makefile.objs | 1

[Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-06-08 Thread minyard
From: Corey Minyard Some devices, like IPMI, need to add ACPI table entries to report their presence. Add a method for adding these entries. Signed-off-by: Corey Minyard --- hw/acpi/Makefile.objs | 1 + hw/acpi/acpi-dev-tables.c | 80 ++