Re: [Qemu-devel] [PATCH v3 15/18] qapi: Add new clone visitor

2016-05-03 Thread Markus Armbruster
Eric Blake writes: > On 05/02/2016 11:54 AM, Markus Armbruster wrote: > >> >> qapi-types.h grows by 492 lines (19KiB, +19%). Roughly one non-blank >> line per non-simple type, including list types. It's included all over >> the place. >> >> qapi-types.c grows by 4212 lines (92KiB, +90%). >>

Re: [Qemu-devel] [PATCH v3 15/18] qapi: Add new clone visitor

2016-05-02 Thread Eric Blake
On 05/02/2016 11:54 AM, Markus Armbruster wrote: > > qapi-types.h grows by 492 lines (19KiB, +19%). Roughly one non-blank > line per non-simple type, including list types. It's included all over > the place. > > qapi-types.c grows by 4212 lines (92KiB, +90%). > > Is it a good idea to generate

Re: [Qemu-devel] [PATCH v3 15/18] qapi: Add new clone visitor

2016-05-02 Thread Markus Armbruster
Eric Blake writes: > We have a couple places in the code base that want to deep-clone > one QAPI object into another, and they were resorting to serializing > the struct out to QObject then reparsing it. A much more efficient > version can be done by adding a new clone visitor. > > Note that we

[Qemu-devel] [PATCH v3 15/18] qapi: Add new clone visitor

2016-04-28 Thread Eric Blake
We have a couple places in the code base that want to deep-clone one QAPI object into another, and they were resorting to serializing the struct out to QObject then reparsing it. A much more efficient version can be done by adding a new clone visitor. Note that we can only clone objects (includin