Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-06-01 Thread Aaron Lindsay
On Jun 01 16:59, Peter Maydell wrote: > On 1 June 2018 at 16:34, Aaron Lindsay wrote: > >> switch (extract32(id_isar0, 24, 4)) { > >> case 1: > >> set_feature(&features, ARM_FEATURE_THUMB_DIV); > >> break; > >> case 2: > >> set_feature(&features, ARM_FEATURE_ARM_DIV); > >> set_feat

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-06-01 Thread Peter Maydell
On 1 June 2018 at 16:34, Aaron Lindsay wrote: > On Jun 01 09:57, Peter Maydell wrote: >> No; V7VE always implies ARM_DIV. (ARM_DIV doesn't imply V7VE, >> though, which is why it is a separate feature bit.) > > Okay, then I'm confused about some of the preexisting logic in > kvm_arm_get_host_cpu_fe

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-06-01 Thread Aaron Lindsay
On Jun 01 09:57, Peter Maydell wrote: > On 31 May 2018 at 21:39, Aaron Lindsay wrote: > > On May 31 15:18, Peter Maydell wrote: > >>if (arm_feature(env, ARM_FEATURE_V7VE) { > >>/* v7 Virtualization Extensions. In real hardware this implies > >> * EL2 and also the presence of th

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-06-01 Thread Peter Maydell
On 31 May 2018 at 21:39, Aaron Lindsay wrote: > On May 31 15:18, Peter Maydell wrote: >>if (arm_feature(env, ARM_FEATURE_V7VE) { >>/* v7 Virtualization Extensions. In real hardware this implies >> * EL2 and also the presence of the Security Extensions. >> * For QEMU, fo

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-05-31 Thread Aaron Lindsay
On May 31 15:18, Peter Maydell wrote: > On 17 May 2018 at 20:31, Aaron Lindsay wrote: > > On Apr 17 16:00, Peter Maydell wrote: > >> So, the underlying issue here is that there's a QEMU specific > >> fudge going on. Architecturally, if the CPU implements the > >> Virtualization Extensions, then: >

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-05-31 Thread Peter Maydell
On 17 May 2018 at 20:31, Aaron Lindsay wrote: > On Apr 17 16:00, Peter Maydell wrote: >> So, the underlying issue here is that there's a QEMU specific >> fudge going on. Architecturally, if the CPU implements the >> Virtualization Extensions, then: >> * it has Hyp mode >> * it must also implemen

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-05-17 Thread Aaron Lindsay
On Apr 17 16:00, Peter Maydell wrote: > On 17 April 2018 at 15:23, Aaron Lindsay wrote: > > On Apr 12 18:17, Peter Maydell wrote: > >> What's the difference between this and ARM_FEATURE_EL2 ? > > > > I use ARM_FEATURE_V7VE in a later patch to guard against implementing > > PMOVSSET on v7 machines

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-04-24 Thread Aaron Lindsay
On Apr 17 16:00, Peter Maydell wrote: > On 17 April 2018 at 15:23, Aaron Lindsay wrote: > > On Apr 12 18:17, Peter Maydell wrote: > >> What's the difference between this and ARM_FEATURE_EL2 ? > > > > I use ARM_FEATURE_V7VE in a later patch to guard against implementing > > PMOVSSET on v7 machines

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 15:23, Aaron Lindsay wrote: > On Apr 12 18:17, Peter Maydell wrote: >> What's the difference between this and ARM_FEATURE_EL2 ? > > I use ARM_FEATURE_V7VE in a later patch to guard against implementing > PMOVSSET on v7 machines which don't implement the virtualization > extensi

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-04-17 Thread Aaron Lindsay
On Apr 12 18:17, Peter Maydell wrote: > On 16 March 2018 at 20:31, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/cpu.c | 3 +++ > > target/arm/cpu.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > > index b0d03

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-04-12 Thread Peter Maydell
On 16 March 2018 at 20:31, Aaron Lindsay wrote: > Signed-off-by: Aaron Lindsay > --- > target/arm/cpu.c | 3 +++ > target/arm/cpu.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index b0d032c..e544f1d 100644 > --- a/target/arm/cpu.c > +++ b/targ

[Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-03-16 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay --- target/arm/cpu.c | 3 +++ target/arm/cpu.h | 1 + 2 files changed, 4 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index b0d032c..e544f1d 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -765,6 +765,7 @@ static void arm_cpu_realizefn(Devic