Re: [Qemu-devel] [PATCH v3 16/19] target-i386: cpu: do not ignore error and fix apic parent

2016-07-13 Thread Eduardo Habkost
On Wed, Jul 06, 2016 at 08:20:52AM +0200, Igor Mammedov wrote: > object_property_add_child() silently fails with error that it can't > create duplicate propery 'apic' as we already have 'apic' property > registered for 'apic' feature. As result generic device_realize puts > apic into unattached

[Qemu-devel] [PATCH v3 16/19] target-i386: cpu: do not ignore error and fix apic parent

2016-07-06 Thread Igor Mammedov
object_property_add_child() silently fails with error that it can't create duplicate propery 'apic' as we already have 'apic' property registered for 'apic' feature. As result generic device_realize puts apic into unattached container. As it's programming error, abort if name collision happens in