Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-22 Thread Peter Maydell
On 22 May 2014 01:48, Edgar E. Iglesias wrote: > On Wed, May 21, 2014 at 08:20:20PM +0100, Peter Maydell wrote: >> it needs to also fix the bit in the "returning to an exception >> level which is 32 bit" which says "new_el = 0" since that's >> not guaranteed to be true any more. (Also I think the

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:10:53PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Adds support for ERET to Aarch64 EL2 and 3. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/op_helper.c | 10 +- > > 1 fi

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:20:20PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Adds support for ERET to Aarch64 EL2 and 3. > > "AArch64". Also "to" here is ambiguous. The ARM ARM tries to Changed to AArch64. > keep the term

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Adds support for ERET to Aarch64 EL2 and 3. "AArch64". Also "to" here is ambiguous. The ARM ARM tries to keep the terminology straight to avoid confusion: exceptions are "taken from ELx" and "taken to ELx"; we "return

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Adds support for ERET to Aarch64 EL2 and 3. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target-arm/op_helper

[Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Adds support for ERET to Aarch64 EL2 and 3. Signed-off-by: Edgar E. Iglesias --- target-arm/op_helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index d89755a..c632dd6 100644 --- a/t