Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-13 Thread Andreas Färber
Am 11.03.2014 10:52, schrieb Mark Wu: On 03/10/2014 10:52 PM, Paolo Bonzini wrote: Il 10/03/2014 15:37, Mark Wu ha scritto: Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in

Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-11 Thread Mark Wu
On 03/10/2014 10:52 PM, Paolo Bonzini wrote: Il 10/03/2014 15:37, Mark Wu ha scritto: Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series,

Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-11 Thread Paolo Bonzini
Il 11/03/2014 10:52, Mark Wu ha scritto: Reviewed-by: Paolo Bonzini pbonz...@redhat.com Thanks a lot for the review. You contributed a lot on this patch, but I forgot to acknowledge it in commit message. I think re-sending a new patch to include it could cause some noise. May I ask the

[Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-10 Thread Mark Wu
Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_init should return true if it's told that the vga will be initialized in flow of the

Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-10 Thread Paolo Bonzini
Il 10/03/2014 15:37, Mark Wu ha scritto: Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_init should return true if it's told that the