Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Peter Maydell wrote: > On 16 October 2014 13:29, Stefano Stabellini > wrote: > > Unfortunately even though it is pretty x86 specific, it is still > > compiled on ARM, even though it is never actually used (it is used in > > i386 emulation with Xen acceleration support, while o

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Peter Maydell
On 16 October 2014 13:29, Stefano Stabellini wrote: > Unfortunately even though it is pretty x86 specific, it is still > compiled on ARM, even though it is never actually used (it is used in > i386 emulation with Xen acceleration support, while on ARM we only use > the PV machine). Really? CONFIG

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Wed, 15 Oct 2014, Peter Maydell wrote: > On 15 October 2014 11:16, Paul Durrant wrote: > > The ioreq-server API added to Xen 4.5 offers better security than > > the existing Xen/QEMU interface because the shared pages that are > > used to pass emulation request/results back and forth are remove

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 15 October 2014 15:38 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > > Stabellini; Peter Maydell; P

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 16 October 2014 11:17 > To: 'Paolo Bonzini'; Peter Maydell > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > Alexey Kardashevskiy; Alexan

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 16/10/2014 12:16, Paul Durrant ha scritto: >> What exactly is the right semantics? Note that save _can_ fail, >> so you need the ability to roll back to the source machine. I >> think this is missing from your patch, and there is no post_save >> hook that you can use. > > I need something tha

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: 16 October 2014 11:10 > To: Paul Durrant; Peter Maydell > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > A

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 16/10/2014 10:25, Paul Durrant ha scritto: >>> +static void xen_hvm_pre_save(void *opaque) >>> +{ >>> +XenIOState *state = opaque; >>> + >>> +/* Stop servicing emulation requests */ >>> +xen_set_ioreq_server_state(xen_xc, xen_domid, state->ioservid, 0); >>> +xen_destroy_ioreq_ser

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 15 October 2014 15:38 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini; Peter Maydell; Paolo Bonzini; Michael Tokarev; Stefan Hajnoczi; > Ste

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: 16 October 2014 08:37 > To: Peter Maydell; Paul Durrant > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > A

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 15 October 2014 18:30 > To: Paul Durrant > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Paolo Bonzini; Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; > Gerd Hoffma

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 15/10/2014 19:30, Peter Maydell ha scritto: > On 15 October 2014 11:16, Paul Durrant wrote: >> The ioreq-server API added to Xen 4.5 offers better security than >> the existing Xen/QEMU interface because the shared pages that are >> used to pass emulation request/results back and forth are remo

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Peter Maydell
On 15 October 2014 11:16, Paul Durrant wrote: > The ioreq-server API added to Xen 4.5 offers better security than > the existing Xen/QEMU interface because the shared pages that are > used to pass emulation request/results back and forth are removed > from the guest's memory space before any reque

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 15 October 2014 15:38 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini; Peter Maydell; Paolo Bonzini; Michael Tokarev; Stefan Hajnoczi; > Ste

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Stefano Stabellini
On Wed, 15 Oct 2014, Paul Durrant wrote: > The ioreq-server API added to Xen 4.5 offers better security than > the existing Xen/QEMU interface because the shared pages that are > used to pass emulation request/results back and forth are removed > from the guest's memory space before any requests ar

[Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Paul Durrant
The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are serviced. This prevents the guest from mapping