Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Shannon Zhao
On 2015/6/18 19:03, Andrew Jones wrote: > On Thu, Jun 18, 2015 at 06:28:36PM +0800, Shannon Zhao wrote: >> >> >> On 2015/6/17 17:42, Andrew Jones wrote: >>> On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: On 2015/6/16 22:19, Michael S. Tsirkin wrote: > On Tue, Jun

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Andrew Jones
On Thu, Jun 18, 2015 at 06:28:36PM +0800, Shannon Zhao wrote: > > > On 2015/6/17 17:42, Andrew Jones wrote: > > On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/6/16 22:19, Michael S. Tsirkin wrote: > >>> On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao w

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Shannon Zhao
On 2015/6/17 17:42, Andrew Jones wrote: > On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: >> >> >> On 2015/6/16 22:19, Michael S. Tsirkin wrote: >>> On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: On 2015/6/16 2:13, Michael S. Tsirkin wrote: > On Mon

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-17 Thread Andrew Jones
On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: > > > On 2015/6/16 22:19, Michael S. Tsirkin wrote: > > On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/6/16 2:13, Michael S. Tsirkin wrote: > >>> On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter May

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: > > > On 2015/6/16 22:19, Michael S. Tsirkin wrote: > > On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/6/16 2:13, Michael S. Tsirkin wrote: > >>> On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter May

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Shannon Zhao
On 2015/6/16 22:19, Michael S. Tsirkin wrote: > On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: >> >> >> On 2015/6/16 2:13, Michael S. Tsirkin wrote: >>> On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: On 15 June 2015 at 17:32, Andrew Jones wrote: > On Mon,

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Michael S. Tsirkin
On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: > > > On 2015/6/16 2:13, Michael S. Tsirkin wrote: > > On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: > >> On 15 June 2015 at 17:32, Andrew Jones wrote: > >>> On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirki

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Igor Mammedov
On Tue, 16 Jun 2015 09:33:19 +0800 Shannon Zhao wrote: > > > On 2015/6/16 2:13, Michael S. Tsirkin wrote: > > On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: > >> On 15 June 2015 at 17:32, Andrew Jones wrote: > >>> On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Shannon Zhao
On 2015/6/16 2:13, Michael S. Tsirkin wrote: > On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: >> On 15 June 2015 at 17:32, Andrew Jones wrote: >>> On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirkin wrote: On Mon, Jun 15, 2015 at 04:45:58PM +0100, Peter Maydell wrot

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: > On 15 June 2015 at 17:32, Andrew Jones wrote: > > On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirkin wrote: > >> On Mon, Jun 15, 2015 at 04:45:58PM +0100, Peter Maydell wrote: > >> > I'm still confused about when fields in

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 17:32, Andrew Jones wrote: > On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirkin wrote: >> On Mon, Jun 15, 2015 at 04:45:58PM +0100, Peter Maydell wrote: >> > I'm still confused about when fields in these ACPI structs >> > need to be converted to little-endian, and when

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Andrew Jones
On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S. Tsirkin wrote: > On Mon, Jun 15, 2015 at 04:45:58PM +0100, Peter Maydell wrote: > > On 10 June 2015 at 10:52, Andrew Jones wrote: > > > Signed-off-by: Andrew Jones > > > Tested-by: Shannon Zhao > > > --- > > > hw/arm/virt-acpi-build.c | 43 ++

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 04:45:58PM +0100, Peter Maydell wrote: > On 10 June 2015 at 10:52, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > Tested-by: Shannon Zhao > > --- > > hw/arm/virt-acpi-build.c | 43 ++- > > 1 file changed, 42 insertions(+),

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-15 Thread Peter Maydell
On 10 June 2015 at 10:52, Andrew Jones wrote: > Signed-off-by: Andrew Jones > Tested-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-11 Thread Igor Mammedov
On Wed, 10 Jun 2015 05:52:39 -0400 Andrew Jones wrote: > Signed-off-by: Andrew Jones > Tested-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > hw/arm/virt-acpi-build.c | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/hw/

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 05:52:39AM -0400, Andrew Jones wrote: > Signed-off-by: Andrew Jones > Tested-by: Shannon Zhao Acked-by: Michael S. Tsirkin > --- > hw/arm/virt-acpi-build.c | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --g

[Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-10 Thread Andrew Jones
Signed-off-by: Andrew Jones Tested-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index a9373ccaca6cb..d5a8b9c0178ea 100644 --- a/hw/