Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-25 Thread Roman Kagan
On Thu, Dec 24, 2015 at 08:17:45AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote: > > On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > > > On Wed, 23 Dec 2015 20:20:54 +0300 > > > Roman Kagan wrote: > > > > > ... two 1.44M drives wit

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Michael S. Tsirkin
On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > > On Wed, 23 Dec 2015 20:20:54 +0300 > > Roman Kagan wrote: > > > > ... two 1.44M drives with bogus geometry for q35. > > > > > > This one is a bug in my patch, indeed:

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > On Wed, 23 Dec 2015 20:20:54 +0300 > Roman Kagan wrote: > > > ... two 1.44M drives with bogus geometry for q35. > > > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE > > being non-zero, and forgot to initia

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Igor Mammedov
On Wed, 23 Dec 2015 20:20:54 +0300 Roman Kagan wrote: > On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote: > > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > > > This is the actual vs expected diff with both patches applied. > > > > Interesting... The diff sugge

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > > This is the actual vs expected diff with both patches applied. > > Interesting... The diff suggests that qemu running in your test > environment has no floppy dri

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > This is the actual vs expected diff with both patches applied. Interesting... The diff suggests that qemu running in your test environment has no floppy drives, while in mine ... > +Scope (\_SB.PCI0.ISA.FDC0) > +{ > +

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Michael S. Tsirkin
On Wed, Dec 23, 2015 at 04:08:19PM +0300, Roman Kagan wrote: > On Tue, Dec 22, 2015 at 06:41:47PM +0200, Michael S. Tsirkin wrote: > > On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote: > > > Update the expected SSDTs to reflect the changes introduced in the > > > previous patch. > > > >

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Tue, Dec 22, 2015 at 06:41:47PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote: > > Update the expected SSDTs to reflect the changes introduced in the > > previous patch. > > > > Signed-off-by: Roman Kagan > > Signed-off-by: Denis V. Lunev > > C

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-22 Thread Michael S. Tsirkin
On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote: > Update the expected SSDTs to reflect the changes introduced in the > previous patch. > > Signed-off-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael S. Tsirkin > CC: Igor Mammedov > CC: Paolo Bonzini > CC: Richard Hen

[Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-18 Thread Roman Kagan
Update the expected SSDTs to reflect the changes introduced in the previous patch. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: John Snow CC: Kevin Wolf --- changes since v