Re: [Qemu-devel] [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-19 Thread Amos Kong
On Fri, Jan 18, 2013 at 12:00:42PM +0100, Stefan Hajnoczi wrote: > On Thu, Jan 17, 2013 at 06:40:12PM +0800, ak...@redhat.com wrote: > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 395ab4f..837c978 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio

Re: [Qemu-devel] [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 06:40:12PM +0800, ak...@redhat.com wrote: > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 395ab4f..837c978 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -802,14 +802,32 @@ static int virtnet_set_mac_address(struct ne

[Qemu-devel] [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-17 Thread akong
From: Amos Kong Currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibility. Signe