Re: [Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/06/2013 04:19 AM, Peter Crosthwaite wrote: Hi JC, On Mon, May 6, 2013 at 12:28 AM, Jean-Christophe DUBOIS wrote: The slave mode is not implemented. Changes since v1: * use QOM cast * run checkpatch on code * added restrictin on MemoryRegionOps * use DeviceClass::real

Re: [Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Peter Crosthwaite
Hi JC, On Mon, May 6, 2013 at 12:28 AM, Jean-Christophe DUBOIS wrote: > The slave mode is not implemented. > > Changes since v1: > * use QOM cast > * run checkpatch on code > * added restrictin on MemoryRegionOps > * use DeviceClass::realise as init function > > Changes since v2:

[Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Jean-Christophe DUBOIS
The slave mode is not implemented. Changes since v1: * use QOM cast * run checkpatch on code * added restrictin on MemoryRegionOps * use DeviceClass::realise as init function Changes since v2: * use CamelCase for state type * use extrac32() for bit manipilation. * impr