Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files

2014-11-26 Thread Max Reitz
On 2014-11-26 at 06:35, Fam Zheng wrote: On Mon, 11/24 10:43, Max Reitz wrote: @@ -1209,7 +1218,13 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *options, Error **errp) QDECREF(options); goto free_exit; } else { -bdrv_get_full_backing_filename(bs, b

Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files

2014-11-26 Thread Max Reitz
On 2014-11-25 at 20:57, Eric Blake wrote: On 11/24/2014 02:43 AM, Max Reitz wrote: When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2

Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files

2014-11-25 Thread Fam Zheng
On Mon, 11/24 10:43, Max Reitz wrote: > @@ -1209,7 +1218,13 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict > *options, Error **errp) > QDECREF(options); > goto free_exit; > } else { > -bdrv_get_full_backing_filename(bs, backing_filename, PATH_MAX); > +

Re: [Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files

2014-11-25 Thread Eric Blake
On 11/24/2014 02:43 AM, Max Reitz wrote: > When using a relative backing file name, qemu needs to know the > directory of the top image file. For JSON filenames, such a directory > cannot be easily determined (e.g. how do you determine the directory of > a qcow2 BDS directly on top of a quorum BDS?

[Qemu-devel] [PATCH v3 2/5] block: JSON filenames and relative backing files

2014-11-24 Thread Max Reitz
When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow relative filenames for