[Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-07-28 Thread Aleksandr Bezzubikov
Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the DMI-to-PCI Bridge in an overwhelming majority of use-cases. Signed-off-by: Aleksandr Bezzubikov --- hw/pci-bridge/Makefile

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-07-31 Thread Marcel Apfelbaum
On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the DMI-to-PCI Bridge in an overwhelming majority of use-cases. Signed-off-by:

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-07-31 Thread Alexander Bezzubikov
2017-07-31 14:23 GMT+03:00 Marcel Apfelbaum : > On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: >> >> Introduce a new PCIExpress-to-PCI Bridge device, >> which is a hot-pluggable PCI Express device and >> supports devices hot-plug with SHPC. >> >> This device is intended to replace the DMI-to-PCI >

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Michael S. Tsirkin
On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > >> +typedef struct PCIEPCIBridge { > >> +/*< private >*/ > >> +PCIBridge parent_obj; > >> + > >> +bool msi_enable; > > > > > > Please rename the msi_enable property to "msi" in order > > to be aligned with the exist

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Marcel Apfelbaum
On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +PCIBridge parent_obj; + +bool msi_enable; Please rename the msi_enable property to "msi" in order to be aligned wi

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Michael S. Tsirkin
On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: > On 01/08/2017 18:32, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > > > > > +typedef struct PCIEPCIBridge { > > > > > +/*< private >*/ > > > > > +PCIBridge parent_obj;

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Marcel Apfelbaum
On 01/08/2017 18:51, Michael S. Tsirkin wrote: On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +PCIBri