Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-15 Thread Richard Henderson
On 07/14/2017 10:25 PM, Aurelien Jarno wrote: That said I still wonder if we can get generators like that: | static void in1_r1n(DisasContext *s, DisasFields *f, DisasOps *o) | { | int r1 = get_field(s->fields, r1); | o->in1 = tcg_const_i32(r1); | | #define SPEC_in1_r1n 0 and | static

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-15 Thread Aurelien Jarno
On 2017-07-14 14:23, Richard Henderson wrote: > On 07/14/2017 11:08 AM, Aurelien Jarno wrote: > > On 2017-07-11 17:18, Thomas Huth wrote: > > > On 10.07.2017 22:45, Richard Henderson wrote: > > > > Signed-off-by: Richard Henderson > > > > --- > > > > target/s390x/helper.h | 6 + > > > >

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Richard Henderson
On 07/14/2017 11:08 AM, Aurelien Jarno wrote: On 2017-07-11 17:18, Thomas Huth wrote: On 10.07.2017 22:45, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/helper.h | 6 + target/s390x/mem_helper.c | 310 + targe

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Aurelien Jarno
On 2017-07-11 17:18, Thomas Huth wrote: > On 10.07.2017 22:45, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > > --- > > target/s390x/helper.h | 6 + > > target/s390x/mem_helper.c | 310 > > + > > target/s390x/translate.c | 4

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Aurelien Jarno
On 2017-07-10 10:45, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/translate.c | 43 +++ > target/s390x/insn-data.def | 13 ++ > 4

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-11 Thread Thomas Huth
On 10.07.2017 22:45, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/translate.c | 43 +++ > target/s390x/insn-data.def | 13 ++ > 4

[Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/helper.h | 6 + target/s390x/mem_helper.c | 310 + target/s390x/translate.c | 43 +++ target/s390x/insn-data.def | 13 ++ 4 files changed, 372 insertions(+) diff --git a/target/s390x/hel