Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-04 Thread John Snow
On 09/03/2018 10:11 AM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben: >>> John Snow writes: >>> On 08/31/2018 02:08 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/29/2018 08:57 PM, John Snow wrote:

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-03 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben: >> John Snow writes: >> >> > On 08/31/2018 02:08 AM, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >>> On 08/29/2018 08:57 PM, John Snow wrote: >> Jobs presently use both an Error object in the

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-03 Thread Kevin Wolf
Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben: > John Snow writes: > > > On 08/31/2018 02:08 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >>> On 08/29/2018 08:57 PM, John Snow wrote: > Jobs presently use both an Error object in the case of the create job, >

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-01 Thread Markus Armbruster
John Snow writes: > On 08/31/2018 02:08 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/29/2018 08:57 PM, John Snow wrote: Jobs presently use both an Error object in the case of the create job, and char strings in the case of generic errors elsewhere. Unify

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-08-31 Thread John Snow
On 08/31/2018 02:08 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/29/2018 08:57 PM, John Snow wrote: >>> Jobs presently use both an Error object in the case of the create job, >>> and char strings in the case of generic errors elsewhere. >>> >>> Unify the two paths as just

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-08-31 Thread Markus Armbruster
Eric Blake writes: > On 08/29/2018 08:57 PM, John Snow wrote: >> Jobs presently use both an Error object in the case of the create job, >> and char strings in the case of generic errors elsewhere. >> >> Unify the two paths as just j->err, and remove the extra argument from >> job_completed. The

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-08-30 Thread Eric Blake
On 08/29/2018 08:57 PM, John Snow wrote: Jobs presently use both an Error object in the case of the create job, and char strings in the case of generic errors elsewhere. Unify the two paths as just j->err, and remove the extra argument from job_completed. The integer error code for

[Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-08-29 Thread John Snow
Jobs presently use both an Error object in the case of the create job, and char strings in the case of generic errors elsewhere. Unify the two paths as just j->err, and remove the extra argument from job_completed. The integer error code for job_completed is kept for now, to be removed shortly in