Re: [Qemu-devel] [PATCH v3 2/9] ppc4xx_i2c: Implement directcntl register

2018-06-17 Thread David Gibson
On Thu, Jun 14, 2018 at 09:51:33AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > > > Signed-off-by: BALATON Zoltan > > > > Patch looks good, but it needs a commit message. What is the > > directcntl r

Re: [Qemu-devel] [PATCH v3 2/9] ppc4xx_i2c: Implement directcntl register

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Patch looks good, but it needs a commit message. What is the directcntl register? Now does the bitbang interface play into that? (Note that I know the answe

Re: [Qemu-devel] [PATCH v3 2/9] ppc4xx_i2c: Implement directcntl register

2018-06-13 Thread David Gibson
On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan Patch looks good, but it needs a commit message. What is the directcntl register? Now does the bitbang interface play into that? (Note that I know the answer to those questions right now, but it need

[Qemu-devel] [PATCH v3 2/9] ppc4xx_i2c: Implement directcntl register

2018-06-13 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppcemb-softmmu.mak | 1 + hw/i2c/ppc4xx_i2c.c| 13 - include/hw/i2c/ppc4xx_i2c.h| 4 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/default-confi