Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-25 Thread Aurelien Jarno
On 2015-09-22 13:25, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 40 - > tcg/tcg.h | 4 +- > translate-all.c

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-25 Thread Richard Henderson
On 09/25/2015 02:10 PM, Aurelien Jarno wrote: >> +if (more) >> + byte |= 0x80; > > You are missing braces here. Gah. I thought I fixed that... > Given we save both the host and the guest PC in this structure, one > obvious optimization would be to skip saving data for host

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 40 - > tcg/tcg.h |

[Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-22 Thread Richard Henderson
We can now restore state without retranslation. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 + tcg/tcg.c | 40 - tcg/tcg.h | 4 +- translate-all.c | 149 +++-