Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-11-06 Thread Palmer Dabbelt
On Mon, 05 Nov 2018 09:00:10 PST (-0800), Bastian Koppelmann wrote: On 11/1/18 4:59 PM, Palmer Dabbelt wrote: On Wed, 31 Oct 2018 15:38:08 PDT (-0700), richard.hender...@linaro.org wrote: On 10/31/18 1:20 PM, Bastian Koppelmann wrote:  static bool trans_slt(DisasContext *ctx, arg_slt *a)  {

Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-11-05 Thread Bastian Koppelmann
On 11/1/18 4:59 PM, Palmer Dabbelt wrote: On Wed, 31 Oct 2018 15:38:08 PDT (-0700), richard.hender...@linaro.org wrote: On 10/31/18 1:20 PM, Bastian Koppelmann wrote:  static bool trans_slt(DisasContext *ctx, arg_slt *a)  { -    gen_arith(ctx, OPC_RISC_SLT, a->rd, a->rs1, a->rs2); +    TCGv

Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-11-01 Thread Palmer Dabbelt
On Wed, 31 Oct 2018 15:38:08 PDT (-0700), richard.hender...@linaro.org wrote: On 10/31/18 1:20 PM, Bastian Koppelmann wrote: static bool trans_slt(DisasContext *ctx, arg_slt *a) { -gen_arith(ctx, OPC_RISC_SLT, a->rd, a->rs1, a->rs2); +TCGv source1 = tcg_temp_new(); +TCGv source2 =

Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > static bool trans_slt(DisasContext *ctx, arg_slt *a) > { > -gen_arith(ctx, OPC_RISC_SLT, a->rd, a->rs1, a->rs2); > +TCGv source1 = tcg_temp_new(); > +TCGv source2 = tcg_temp_new(); > + > +gen_get_gpr(source1, a->rs1); > +

[Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-10-31 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn_trans/trans_rvi.inc.c | 78 + target/riscv/translate.c| 59 ++- 2 files changed, 85 insertions(+), 52 deletions(-) diff