Re: [Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-24 Thread Aggeler Fabian
On 17 Jun 2014, at 08:12, Edgar E. Iglesias wrote: > On Fri, Jun 13, 2014 at 05:06:15PM -0500, Greg Bellows wrote: >> I just wanted to point out that the change from array-notation to hard-code >> numbers in the names undoes Edgar's EL2/EL3 changes. I prefer this way >> over the array notation.

Re: [Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-23 Thread Greg Bellows
I agree, if we are going to allow for EL-based array indexing then the indices should correspond to the actual EL for clarity. I am fine with the above compromise. On 17 June 2014 01:12, Edgar E. Iglesias wrote: > On Fri, Jun 13, 2014 at 05:06:15PM -0500, Greg Bellows wrote: > > I just wanted

Re: [Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-16 Thread Edgar E. Iglesias
On Fri, Jun 13, 2014 at 05:06:15PM -0500, Greg Bellows wrote: > I just wanted to point out that the change from array-notation to hard-code > numbers in the names undoes Edgar's EL2/EL3 changes. I prefer this way > over the array notation. Hi, This was discussed briefly here http://lists.gnu.org

Re: [Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-13 Thread Greg Bellows
I just wanted to point out that the change from array-notation to hard-code numbers in the names undoes Edgar's EL2/EL3 changes. I prefer this way over the array notation. On 10 June 2014 18:55, Fabian Aggeler wrote: > When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) > DFSR h

[Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-10 Thread Fabian Aggeler
When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) DFSR has a secure and a non-secure instance. Signed-off-by: Fabian Aggeler --- target-arm/cpu.h| 13 - target-arm/helper-a64.c | 17 ++--- target-arm/helper.c | 15 --- 3 files chan