On Mon, 2018-09-10 at 14:38 -0300, Eduardo Habkost wrote:
> On Thu, Sep 06, 2018 at 06:00:29AM +, Hu, Robert wrote:
> >
> > >
> > > Yeah, since this type is used in the qom-get backdoor that evades
> > > introspection,
> > > it's even more important that you follow the backwards-
> > >
On Thu, Sep 06, 2018 at 06:00:29AM +, Hu, Robert wrote:
>
> > -Original Message-
> > From: Eric Blake [mailto:ebl...@redhat.com]
> > Sent: Thursday, September 6, 2018 1:41
> > To: Eduardo Habkost
> > Cc: Robert Hoo ; Paolo Bonzini
> > ; Hu, Robert ; r...@twiddle.net;
> >
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Thursday, September 6, 2018 1:41
> To: Eduardo Habkost
> Cc: Robert Hoo ; Paolo Bonzini
> ; Hu, Robert ; r...@twiddle.net;
> thomas.lenda...@amd.com; qemu-devel@nongnu.org; Liu, Jingqi
> ; Markus Armbruster ; Jiri
On 09/05/2018 11:44 AM, Eduardo Habkost wrote:
On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote:
On 09/05/2018 09:10 AM, Eduardo Habkost wrote:
Question to the QAPI schema maintainers below:
##
-{ 'struct': 'X86CPUFeatureWordInfo',
- 'data': { 'cpuid-input-eax': 'int',
-
On Wed, Sep 05, 2018 at 10:32:33AM -0500, Eric Blake wrote:
> On 09/05/2018 09:10 AM, Eduardo Habkost wrote:
> > Question to the QAPI schema maintainers below:
> >
>
> > > ##
> > > -{ 'struct': 'X86CPUFeatureWordInfo',
> > > - 'data': { 'cpuid-input-eax': 'int',
> > > -
On 09/05/2018 09:10 AM, Eduardo Habkost wrote:
Question to the QAPI schema maintainers below:
##
-{ 'struct': 'X86CPUFeatureWordInfo',
- 'data': { 'cpuid-input-eax': 'int',
-'*cpuid-input-ecx': 'int',
-'cpuid-register': 'X86CPURegister32',
+{ 'struct':
Question to the QAPI schema maintainers below:
On Wed, Sep 05, 2018 at 01:47:55PM +0800, Robert Hoo wrote:
> On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote:
> > On 10/08/2018 16:06, Robert Hoo wrote:
> > > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
> >
> > This should
On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote:
> On 10/08/2018 16:06, Robert Hoo wrote:
> > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
>
> This should also grow support for MSR feature words.
>
> My suggestion is that you add another patch after patch 1 that expands
On Sat, Aug 18, 2018 at 05:01:45PM +0800, Robert Hoo wrote:
> On Fri, 2018-08-17 at 10:28 -0300, Eduardo Habkost wrote:
> > On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote:
> > > Add an util function feature_word_description(), which help construct the
> > > string
> > > describing the
On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote:
> On 10/08/2018 16:06, Robert Hoo wrote:
> > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
>
> This should also grow support for MSR feature words.
>
> My suggestion is that you add another patch after patch 1 that expands
On Fri, 2018-08-17 at 10:28 -0300, Eduardo Habkost wrote:
> On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote:
> > Add an util function feature_word_description(), which help construct the
> > string
> > describing the feature word (both CPUID and MSR types).
> >
> >
On 10/08/2018 16:06, Robert Hoo wrote:
> x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
This should also grow support for MSR feature words.
My suggestion is that you add another patch after patch 1 that expands
the definition of X86CPUFeatureWordInfo like this, and adjusts
On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote:
> Add an util function feature_word_description(), which help construct the
> string
> describing the feature word (both CPUID and MSR types).
>
> report_unavailable_features(): add MSR_FEATURE_WORD type support.
>
On Fri, 2018-08-10 at 10:17 -0500, Eric Blake wrote:
> On 08/10/2018 09:06 AM, Robert Hoo wrote:
>
> In the subject: s/funcitons/functions/
>
> Also, it may be worth using a topic prefix (most of our commit messages
> resemble:
>
> topic: Description of patch
>
> to make it easier to spot
On 08/10/2018 09:06 AM, Robert Hoo wrote:
In the subject: s/funcitons/functions/
Also, it may be worth using a topic prefix (most of our commit messages
resemble:
topic: Description of patch
to make it easier to spot patches by topic).
Add an util function feature_word_description(),
Add an util function feature_word_description(), which help construct the string
describing the feature word (both CPUID and MSR types).
report_unavailable_features(): add MSR_FEATURE_WORD type support.
x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only.
16 matches
Mail list logo
