Re: [Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-08 Thread Cao jin
On 01/08/2016 12:51 AM, Eric Blake wrote: On 01/07/2016 01:12 AM, Cao jin wrote: if (rc < 0) { -XEN_PT_LOG(>dev, "Failed to initialize %d/%ld, type=0x%x, rc:%d\n", - i, ARRAY_SIZE(xen_pt_emu_reg_grps), +error_setg(_err,

Re: [Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-07 Thread Cao jin
On 01/07/2016 12:02 AM, Eric Blake wrote: On 01/05/2016 07:39 PM, Cao jin wrote: [...] +static void xen_pt_config_reg_init(XenPCIPassthroughState *s, + XenPTRegGroup *reg_grp, XenPTRegInfo *reg, + Error **errp) Indentation

Re: [Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-07 Thread Eric Blake
On 01/07/2016 01:12 AM, Cao jin wrote: >>> if (rc < 0) { >>> -XEN_PT_LOG(>dev, "Failed to initialize %d/%ld, >>> type=0x%x, rc:%d\n", >>> - i, ARRAY_SIZE(xen_pt_emu_reg_grps), >>> +error_setg(_err, "Failed to initialize

Re: [Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-06 Thread Eric Blake
On 01/05/2016 07:39 PM, Cao jin wrote: > To catch the error msg. Also modify the caller > > Signed-off-by: Cao jin > --- > hw/xen/xen_pt.c | 7 --- > hw/xen/xen_pt.h | 2 +- > hw/xen/xen_pt_config_init.c | 51 >

[Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-05 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen_pt.c | 7 --- hw/xen/xen_pt.h | 2 +- hw/xen/xen_pt_config_init.c | 51 - 3 files changed, 32 insertions(+),