Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

2017-05-04 Thread Pradeep Jagadeesh
On 5/3/2017 7:21 PM, Greg Kurz wrote: On Tue, 2 May 2017 17:15:02 -0500 Eric Blake wrote: On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: This patchset factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Instead of adding the duplicat

Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

2017-05-03 Thread Greg Kurz
On Tue, 2 May 2017 17:15:02 -0500 Eric Blake wrote: > On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > > This patchset factor out the duplicate qmp throttle interface code > > that was present in both block and fsdev device files. > > Instead of adding the duplicate code in patch 2 then clea

Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

2017-05-02 Thread Eric Blake
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > This patchset factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. Instead of adding the duplicate code in patch 2 then cleaning it out here, you should refactor this patch to be first (fix

[Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

2017-05-02 Thread Pradeep Jagadeesh
This patchset factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 53 +++-- fsdev/qemu-fsdev-throttle.c | 51 +---