Re: [Qemu-devel] [PATCH v3 3/5] crypto/block: rename qcrypto_block_*crypt_helper

2018-12-10 Thread Alberto Garcia
On Mon 10 Dec 2018 02:21:56 PM CET, Daniel P. Berrangé wrote: > On Mon, Dec 10, 2018 at 11:44:22AM +0100, Alberto Garcia wrote: >> On Fri 07 Dec 2018 05:13:49 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> > Rename qcrypto_block_*crypt_helper to qcrypto_cipher_*crypt_helper, as >> >> You forgot to

Re: [Qemu-devel] [PATCH v3 3/5] crypto/block: rename qcrypto_block_*crypt_helper

2018-12-10 Thread Daniel P . Berrangé
On Mon, Dec 10, 2018 at 11:44:22AM +0100, Alberto Garcia wrote: > On Fri 07 Dec 2018 05:13:49 PM CET, Vladimir Sementsov-Ogievskiy wrote: > > Rename qcrypto_block_*crypt_helper to qcrypto_cipher_*crypt_helper, as > > You forgot to update the new function names in the commit message. > > > -int qc

Re: [Qemu-devel] [PATCH v3 3/5] crypto/block: rename qcrypto_block_*crypt_helper

2018-12-10 Thread Alberto Garcia
On Fri 07 Dec 2018 05:13:49 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Rename qcrypto_block_*crypt_helper to qcrypto_cipher_*crypt_helper, as You forgot to update the new function names in the commit message. > -int qcrypto_block_decrypt_helper(QCryptoCipher *cipher, > -int qcrypto_block_encry

[Qemu-devel] [PATCH v3 3/5] crypto/block: rename qcrypto_block_*crypt_helper

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
Rename qcrypto_block_*crypt_helper to qcrypto_cipher_*crypt_helper, as it's not about QCryptoBlock. This is needed to introduce qcrypto_block_*crypt_helper in the next commit, which will have QCryptoBlock pointer and than will be able to use additional fields of it, which in turn will be used to im