Re: [Qemu-devel] [PATCH v3 32/44] nbd: Share common option-sending code in client

2016-04-25 Thread Alex Bligh
On 23 Apr 2016, at 00:40, Eric Blake wrote: > Rather than open-coding each option request, it's easier to > have common helper functions do the work. That in turn requires > having convenient packed types for handling option requests > and replies. > > Signed-off-by: Eric Blake > Reviewed-by:

[Qemu-devel] [PATCH v3 32/44] nbd: Share common option-sending code in client

2016-04-22 Thread Eric Blake
Rather than open-coding each option request, it's easier to have common helper functions do the work. That in turn requires having convenient packed types for handling option requests and replies. Signed-off-by: Eric Blake Reviewed-by: Alex Bligh --- v3: rebase, tweak a debug message --- incl