Re: [Qemu-devel] [PATCH v3 33/34] target-alpha: Introduce MMU_PHYS_IDX

2016-09-15 Thread Richard Henderson
On 09/15/2016 03:10 AM, Alex Bennée wrote: /* User-space cannot access KSEG addresses. */ > -if (mmu_idx != MMU_KERNEL_IDX) { > +if (mmu_idx < MMU_KERNEL_IDX) { > goto exit; > } I'm confused by this change. It's not the same test and when is mmu_id

Re: [Qemu-devel] [PATCH v3 33/34] target-alpha: Introduce MMU_PHYS_IDX

2016-09-15 Thread Alex Bennée
Richard Henderson writes: > Rather than using helpers for physical accesses, use a mmu index. > The primary cleanup is with store-conditional on physical addresses. > > Signed-off-by: Richard Henderson > --- > target-alpha/cpu.h| 18 +--- > target-alpha/helper.c | 10 ++

[Qemu-devel] [PATCH v3 33/34] target-alpha: Introduce MMU_PHYS_IDX

2016-09-03 Thread Richard Henderson
Rather than using helpers for physical accesses, use a mmu index. The primary cleanup is with store-conditional on physical addresses. Signed-off-by: Richard Henderson --- target-alpha/cpu.h| 18 +--- target-alpha/helper.c | 10 ++- target-alpha/helper.h | 9 --