Re: [Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into its only caller

2016-03-19 Thread Marc-André Lureau
Hi On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > Improve the error messages while there. > > Signed-off-by: Markus Armbruster I'd prefer we keep a seperate function to handle the shm checks, but I don't mind much so: Reviewed-by: Marc-André Lureau > --- > hw/misc/ivshmem.c |

Re: [Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into its only caller

2016-03-19 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: >> Improve the error messages while there. >> >> Signed-off-by: Markus Armbruster > > I'd prefer we keep a seperate function to handle the shm checks, but I > don't mind much so: Matter of taste. I re

[Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into its only caller

2016-03-15 Thread Markus Armbruster
Improve the error messages while there. Signed-off-by: Markus Armbruster --- hw/misc/ivshmem.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 1b1de65..e6282ab 100644 --- a/hw/misc/ivshmem.c +