Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

2016-04-25 Thread Eric Blake
On 04/25/2016 01:40 PM, Alex Bligh wrote: > > On 25 Apr 2016, at 20:20, Eric Blake wrote: > } else if (fixedNewstyle) { >>> >>> So the above is for NewStyle (not fixedNewStyle)? >> >> The above is for fixedNewStyle when TLS is not negotiated yet; the 'else >> if' is for fixedNewStyle

Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

2016-04-25 Thread Alex Bligh
On 25 Apr 2016, at 20:20, Eric Blake wrote: >>>} else if (fixedNewstyle) { >> >> So the above is for NewStyle (not fixedNewStyle)? > > The above is for fixedNewStyle when TLS is not negotiated yet; the 'else > if' is for fixedNewStyle after TLS has been negotiated. Prior to TLS, > we

Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

2016-04-25 Thread Eric Blake
On 04/25/2016 03:47 AM, Alex Bligh wrote: > > On 23 Apr 2016, at 00:40, Eric Blake wrote: > >> NBD commit 6d34500b clarified how clients and servers are supposed >> to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN >> (for the server to announce it is about to go away during o

Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

2016-04-25 Thread Alex Bligh
On 23 Apr 2016, at 00:40, Eric Blake wrote: > NBD commit 6d34500b clarified how clients and servers are supposed > to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN > (for the server to announce it is about to go away during option > haggling, so the client should quit sending

[Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

2016-04-22 Thread Eric Blake
NBD commit 6d34500b clarified how clients and servers are supposed to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN (for the server to announce it is about to go away during option haggling, so the client should quit sending NBD_OPT_* other than NBD_OPT_ABORT) and ESHUTDOWN (for