Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-22 Thread Sergey Fedorov
On 22/04/16 00:54, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 21/04/16 19:16, Sergey Fedorov wrote: >>> On 21/04/16 18:55, Alex Bennée wrote: Sergey Fedorov writes: > On 18/04/16 20:51, Sergey Fedorov wrote: >> On 18/04/16 20:17, Alex Bennée wrote: >>> Sergey Fedoro

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-21 Thread Alex Bennée
Sergey Fedorov writes: > On 21/04/16 19:16, Sergey Fedorov wrote: >> On 21/04/16 18:55, Alex Bennée wrote: >>> Sergey Fedorov writes: >>> On 18/04/16 20:51, Sergey Fedorov wrote: > On 18/04/16 20:17, Alex Bennée wrote: >> Sergey Fedorov writes: >>> On 18/04/16 17:09, Alex Benn

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-21 Thread Sergey Fedorov
On 21/04/16 19:16, Sergey Fedorov wrote: > On 21/04/16 18:55, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> On 18/04/16 20:51, Sergey Fedorov wrote: On 18/04/16 20:17, Alex Bennée wrote: > Sergey Fedorov writes: >> On 18/04/16 17:09, Alex Bennée wrote: >>> Sergey Fedorov w

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-21 Thread Sergey Fedorov
On 21/04/16 18:55, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 18/04/16 20:51, Sergey Fedorov wrote: >>> On 18/04/16 20:17, Alex Bennée wrote: Sergey Fedorov writes: > On 18/04/16 17:09, Alex Bennée wrote: >> Sergey Fedorov writes: >>> diff --git a/cpu-exec.c b/cpu-exec.

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-21 Thread Alex Bennée
Sergey Fedorov writes: > On 18/04/16 20:51, Sergey Fedorov wrote: >> On 18/04/16 20:17, Alex Bennée wrote: >>> Sergey Fedorov writes: On 18/04/16 17:09, Alex Bennée wrote: > Sergey Fedorov writes: >> diff --git a/cpu-exec.c b/cpu-exec.c (snip) >> @@ -507,14 +510,12 @@ int

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-21 Thread Sergey Fedorov
On 18/04/16 20:51, Sergey Fedorov wrote: > On 18/04/16 20:17, Alex Bennée wrote: >> Sergey Fedorov writes: >>> On 18/04/16 17:09, Alex Bennée wrote: Sergey Fedorov writes: > diff --git a/cpu-exec.c b/cpu-exec.c >>> (snip) > @@ -507,14 +510,12 @@ int cpu_exec(CPUState *cpu) >

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Sergey Fedorov
On 18/04/16 20:17, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 18/04/16 17:09, Alex Bennée wrote: >>> Sergey Fedorov writes: diff --git a/cpu-exec.c b/cpu-exec.c >> (snip) @@ -507,14 +510,12 @@ int cpu_exec(CPUState *cpu) } tb_lock();

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > On 18/04/16 17:09, Alex Bennée wrote: >> Sergey Fedorov writes: >>> From: Sergey Fedorov >>> >>> 'tb_invalidated_flag' was meant to catch two events: >>> * some TB has been invalidated by tb_phys_invalidate(); >>> * the whole translation buffer has been flushed by tb

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 16:05, Sergey Fedorov wrote: > @@ -507,14 +510,12 @@ int cpu_exec(CPUState *cpu) > } > tb_lock(); > tb = tb_find_fast(cpu); > -/* Note: we do it here to avoid a gcc bug on Mac OS X when > - doi

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Sergey Fedorov
On 18/04/16 17:09, Alex Bennée wrote: > Sergey Fedorov writes: >> From: Sergey Fedorov >> >> 'tb_invalidated_flag' was meant to catch two events: >> * some TB has been invalidated by tb_phys_invalidate(); >> * the whole translation buffer has been flushed by tb_flush(). >> >> Then it was checke

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > 'tb_invalidated_flag' was meant to catch two events: > * some TB has been invalidated by tb_phys_invalidate(); > * the whole translation buffer has been flushed by tb_flush(). > > Then it was checked: > * in cpu_exec() to ensure that the last

[Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-14 Thread Sergey Fedorov
From: Sergey Fedorov 'tb_invalidated_flag' was meant to catch two events: * some TB has been invalidated by tb_phys_invalidate(); * the whole translation buffer has been flushed by tb_flush(). Then it was checked: * in cpu_exec() to ensure that the last executed TB can be safely linked to