Eric Blake ebl...@redhat.com writes:
On 05/06/2015 10:18 AM, John Snow wrote:
To find out, add just buffering. Something like this in your patch
instead of byte2hex():
for (i = 0; i len; i++) {
-qtest_sendf(chr, %02x, data[i]);
+snprintf(enc[i * 2], 2,
On 05/08/2015 02:25 AM, Markus Armbruster wrote:
Eric Blake ebl...@redhat.com writes:
On 05/06/2015 10:18 AM, John Snow wrote:
To find out, add just buffering. Something like this in your patch
instead of byte2hex():
for (i = 0; i len; i++) {
-qtest_sendf(chr,
On 05/08/2015 10:22 AM, John Snow wrote:
I'm a bit surprised - making a function call per byte generally executes
more instructions than open-coding the conversion (albeit the branch
prediction in the hardware probably does fairly well over long strings,
since it is a tight and predictable
On 05/07/2015 02:13 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/06/2015 11:19 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/06/2015 02:25 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of letting printf and
On 05/06/2015 10:18 AM, John Snow wrote:
To find out, add just buffering. Something like this in your patch
instead of byte2hex():
for (i = 0; i len; i++) {
-qtest_sendf(chr, %02x, data[i]);
+snprintf(enc[i * 2], 2, %02x, data[i]);
}
If the
John Snow js...@redhat.com writes:
On 05/06/2015 11:19 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/06/2015 02:25 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of letting printf and friends do this for us
one byte at a time, fill a
John Snow js...@redhat.com writes:
Instead of letting printf and friends do this for us
one byte at a time, fill a buffer ourselves and then
send the entire buffer in one go.
This gives a moderate speed improvement over the old
method.
Out of curiosity: how much of the improvement is due
On 05/06/2015 02:25 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of letting printf and friends do this for us
one byte at a time, fill a buffer ourselves and then
send the entire buffer in one go.
This gives a moderate speed improvement over the old
method.
On 05/06/2015 11:19 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/06/2015 02:25 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of letting printf and friends do this for us
one byte at a time, fill a buffer ourselves and then
send the
John Snow js...@redhat.com writes:
On 05/06/2015 02:25 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of letting printf and friends do this for us
one byte at a time, fill a buffer ourselves and then
send the entire buffer in one go.
This gives a moderate speed
Instead of letting printf and friends do this for us
one byte at a time, fill a buffer ourselves and then
send the entire buffer in one go.
This gives a moderate speed improvement over the old
method.
Signed-off-by: John Snow js...@redhat.com
---
qtest.c | 20
11 matches
Mail list logo
