Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-08 Thread Greg Kurz
On Thu, 8 Jun 2017 13:59:21 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 07:17:17PM +0200, Greg Kurz wrote: > > The ICPState objects are currently registered to vmstate as qdev objects. > > Their instance ids are hence computed automatically in the migration

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-07 Thread David Gibson
On Wed, Jun 07, 2017 at 07:17:17PM +0200, Greg Kurz wrote: > The ICPState objects are currently registered to vmstate as qdev objects. > Their instance ids are hence computed automatically in the migration code, > and thus depends on the order the CPU cores were plugged. > > If the destination

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-07 Thread Greg Kurz
On Wed, 7 Jun 2017 20:14:01 +0200 Cédric Le Goater wrote: > On 06/07/2017 07:17 PM, Greg Kurz wrote: > > The ICPState objects are currently registered to vmstate as qdev objects. > > Their instance ids are hence computed automatically in the migration code, > > and thus depends on

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-07 Thread Cédric Le Goater
On 06/07/2017 07:17 PM, Greg Kurz wrote: > The ICPState objects are currently registered to vmstate as qdev objects. > Their instance ids are hence computed automatically in the migration code, > and thus depends on the order the CPU cores were plugged. > > If the destination had its CPU cores

[Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

2017-06-07 Thread Greg Kurz
The ICPState objects are currently registered to vmstate as qdev objects. Their instance ids are hence computed automatically in the migration code, and thus depends on the order the CPU cores were plugged. If the destination had its CPU cores plugged in a different order than the source, then