Re: [Qemu-devel] [PATCH v3 4/6] pci: remove the limit parameter of pci_host_config_read_common

2015-01-27 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 10:20:26AM +0800, Hu Tao wrote: > Since the limit parameter is always set to the size of pci device's > configuration space, That's not true in case of pci_data_read, is it? While the patch might be correct, a better analysis why that's so seems called for. > and we can d

Re: [Qemu-devel] [PATCH v3 4/6] pci: remove the limit parameter of pci_host_config_read_common

2015-01-21 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 10:20:26AM +0800, Hu Tao wrote: > Since the limit parameter is always set to the size of pci device's > configuration space, and we can determine the size from the type of pci > device. > > Signed-off-by: Hu Tao Not true e.g. for pci_data_read, is it? Need a bit more comm

[Qemu-devel] [PATCH v3 4/6] pci: remove the limit parameter of pci_host_config_read_common

2014-12-10 Thread Hu Tao
Since the limit parameter is always set to the size of pci device's configuration space, and we can determine the size from the type of pci device. Signed-off-by: Hu Tao --- hw/pci/pci_host.c | 15 +++ hw/pci/pcie_host.c| 9 + hw/ppc/spapr_pci.c| 3 +