Re: [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note

2017-07-11 Thread Eduardo Habkost
On Tue, Jul 11, 2017 at 10:04:43PM +0200, Laszlo Ersek wrote: [...] > > +lines = g_strsplit((char *)vmci, "\n", -1); > > +for (i = 0; lines[i]; i++) { > > +if (g_str_has_prefix(lines[i], "NUMBER(phys_base)=")) { > > +if (qemu_strtou64(lines[i] + 18, NULL, 16, > > +

Re: [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note

2017-07-11 Thread Laszlo Ersek
On 07/11/17 12:30, Marc-André Lureau wrote: > Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo > device provides the location, and write it as an ELF note in the dump. > > There are now 2 possible sources of phys_base information. > > (1) arch guessed value from

[Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note

2017-07-11 Thread Marc-André Lureau
Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo device provides the location, and write it as an ELF note in the dump. There are now 2 possible sources of phys_base information. (1) arch guessed value from cpu_get_dump_info() (2) vmcoreinfo ELF note NUMBER(phys_base)= field