Re: [Qemu-devel] [PATCH v3 4/8] iotests: Use case_skip() in skip_if_unsupported()

2019-08-21 Thread Max Reitz
On 20.08.19 23:27, John Snow wrote: > > > On 8/19/19 4:18 PM, Max Reitz wrote: >> skip_if_unsupported() should use the stronger variant case_skip(), >> because this allows it to be used even with setUp() (in a meaningful >> way). >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/iotes

Re: [Qemu-devel] [PATCH v3 4/8] iotests: Use case_skip() in skip_if_unsupported()

2019-08-20 Thread John Snow
On 8/19/19 4:18 PM, Max Reitz wrote: > skip_if_unsupported() should use the stronger variant case_skip(), > because this allows it to be used even with setUp() (in a meaningful > way). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v3 4/8] iotests: Use case_skip() in skip_if_unsupported()

2019-08-19 Thread Max Reitz
skip_if_unsupported() should use the stronger variant case_skip(), because this allows it to be used even with setUp() (in a meaningful way). Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.