Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges

2018-07-06 Thread Aleksandar Markovic
> > case 18: > > switch (sel) { > > -case 0 ... 7: > > +case 0: > > +case 1: > > +case 2: > > +case 3: > > +case 4: > > +case 5: > > +case 6: > > +case 7: > > I don't see the point in this. It is clear what 0

Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges

2018-07-05 Thread Richard Henderson
On 07/04/2018 12:30 PM, Aleksandar Markovic wrote: > case 18: > switch (sel) { > -case 0 ... 7: > +case 0: > +case 1: > +case 2: > +case 3: > +case 4: > +case 5: > +case 6: > +case 7: I don't see the point in

Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges

2018-07-05 Thread Philippe Mathieu-Daudé
On 07/04/2018 05:28 PM, Philippe Mathieu-Daudé wrote: > On 07/04/2018 04:30 PM, Aleksandar Markovic wrote: >> From: Aleksandar Markovic >> >> Remove "range style" case statements to make code analysis easier. > Why not... > >> >> This is needed also for some upcoming nanoMIPS-related

[Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges

2018-07-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove "range style" case statements to make code analysis easier. This is needed also for some upcoming nanoMIPS-related refactorings. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 257 +++- 1 file