Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 09:58:11AM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 21:12, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: > >>> On 04/11/17 02:33, Daniel P. Berrange wrote: > >>>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 07:28:31PM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 21:12, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: > >>> On 04/11/17 02:33, Daniel P. Berrange wrote: > >>>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 15:12, Alexey Kardashevskiy wrote: > > On 04/11/17 02:33, Daniel P. Berrange wrote: > >> We short circuit the git submodule update when passed an empty module list. > >> This accidentally causes the 'status' command

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-06 Thread Alexey Kardashevskiy
On 07/11/17 15:12, Alexey Kardashevskiy wrote: > On 04/11/17 02:33, Daniel P. Berrange wrote: >> We short circuit the git submodule update when passed an empty module list. >> This accidentally causes the 'status' command to write to the status file. >> The >> test needs to be delayed into the ind

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-06 Thread Alexey Kardashevskiy
On 04/11/17 02:33, Daniel P. Berrange wrote: > We short circuit the git submodule update when passed an empty module list. > This accidentally causes the 'status' command to write to the status file. The > test needs to be delayed into the individual commands to avoid this premature > writing of th

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > We short circuit the git submodule update when passed an empty module list. > This accidentally causes the 'status' command to write to the status file. The > test needs to be delayed into the individual commands to avoid this premature > writing

[Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-03 Thread Daniel P. Berrange
We short circuit the git submodule update when passed an empty module list. This accidentally causes the 'status' command to write to the status file. The test needs to be delayed into the individual commands to avoid this premature writing of the status file. Signed-off-by: Daniel P. Berrange --