Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, Jun 13, 2017 at 05:24:28PM +0200, Greg Kurz wrote: > On Tue, 13 Jun 2017 18:01:46 +0800 > David Gibson wrote: > > > On Tue, Jun 13, 2017 at 11:21:50AM +0200, Greg Kurz wrote: > > > On Tue, 13 Jun 2017 10:00:03 +0100 > > > "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, 13 Jun 2017 18:01:46 +0800 David Gibson wrote: > On Tue, Jun 13, 2017 at 11:21:50AM +0200, Greg Kurz wrote: > > On Tue, 13 Jun 2017 10:00:03 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Greg Kurz (gr...@kaod.org) wrote: > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, Jun 13, 2017 at 12:05:52PM +0200, Greg Kurz wrote: > On Tue, 13 Jun 2017 10:55:50 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Tue, 13 Jun 2017 10:00:03 +0100 > > > "Dr. David Alan Gilbert" wrote: >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, Jun 13, 2017 at 11:21:50AM +0200, Greg Kurz wrote: > On Tue, 13 Jun 2017 10:00:03 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Tue, 13 Jun 2017 16:06:31 +0800 > > > David Gibson wrote: > > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, 13 Jun 2017 11:12:17 +0100 "Dr. David Alan Gilbert" wrote: [...] > > > > > > > > > > So what's the problem with a (void *)i ? > > > > > > > > https://stackoverflow.com/questions/8618637/what-does-it-mean-to-convert-int-to-void-or-vice-versa > > > > > > > > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, 13 Jun 2017 10:55:50 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Tue, 13 Jun 2017 10:00:03 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Greg Kurz (gr...@kaod.org) wrote: > > > > On Tue, 13 Jun

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

* Greg Kurz (gr...@kaod.org) wrote: > On Tue, 13 Jun 2017 10:55:50 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Tue, 13 Jun 2017 10:00:03 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Greg

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

* Greg Kurz (gr...@kaod.org) wrote: > On Tue, 13 Jun 2017 10:00:03 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Tue, 13 Jun 2017 16:06:31 +0800 > > > David Gibson wrote: > > > > > > > On Tue, Jun

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, 13 Jun 2017 10:00:03 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Tue, 13 Jun 2017 16:06:31 +0800 > > David Gibson wrote: > > > > > On Tue, Jun 13, 2017 at 09:33:59AM +0200, Greg Kurz wrote: > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

* Greg Kurz (gr...@kaod.org) wrote: > On Tue, 13 Jun 2017 16:06:31 +0800 > David Gibson wrote: > > > On Tue, Jun 13, 2017 at 09:33:59AM +0200, Greg Kurz wrote: > [...] > > > > > > > +static void > > > > > > > pre_2_10_vmstate_register_dummy_icp(sPAPRMachineState

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, 13 Jun 2017 16:06:31 +0800 David Gibson wrote: > On Tue, Jun 13, 2017 at 09:33:59AM +0200, Greg Kurz wrote: [...] > > > > > > +static void pre_2_10_vmstate_register_dummy_icp(sPAPRMachineState > > > > > > *spapr, int i) > > > > > > +{ > > > > > > +bool

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Tue, Jun 13, 2017 at 09:33:59AM +0200, Greg Kurz wrote: > On Mon, 12 Jun 2017 22:24:56 +0800 > David Gibson wrote: > > > On Thu, Jun 08, 2017 at 11:54:10AM +0200, Greg Kurz wrote: > > > On Thu, 8 Jun 2017 14:08:57 +1000 > > > David Gibson

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Mon, 12 Jun 2017 22:24:56 +0800 David Gibson wrote: > On Thu, Jun 08, 2017 at 11:54:10AM +0200, Greg Kurz wrote: > > On Thu, 8 Jun 2017 14:08:57 +1000 > > David Gibson wrote: > > > > > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Thu, Jun 08, 2017 at 11:54:10AM +0200, Greg Kurz wrote: > On Thu, 8 Jun 2017 14:08:57 +1000 > David Gibson wrote: > > > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Thu, 8 Jun 2017 14:08:57 +1000 David Gibson wrote: > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > > sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. > >

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. > This is an improvement since we no longer allocate ICPState objects > that will never be used.

[Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. This is an improvement since we no longer allocate ICPState objects that will never be used. But it has the side-effect of breaking migration of older machine