Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-27 Thread Luiz Capitulino
On Wed, 27 Jun 2012 18:22:48 +0800 Amos Kong wrote: > On 27/06/12 04:21, Luiz Capitulino wrote: > > On Wed, 20 Jun 2012 12:47:40 +0800 > > Amos Kong wrote: > > > >> Convert 'sendkey' to use QAPI. do_sendkey() depends on some > >> variables/functions in monitor.c, so reserve qmp_sendkey() > >> to

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-27 Thread Luiz Capitulino
On Wed, 27 Jun 2012 17:59:04 +0800 Amos Kong wrote: > On 27/06/12 04:22, Luiz Capitulino wrote: > > On Wed, 20 Jun 2012 06:53:40 -0600 > > Eric Blake wrote: > > > >> On 06/19/2012 10:47 PM, Amos Kong wrote: > >>> Convert 'sendkey' to use QAPI. do_sendkey() depends on some > >>> variables/functio

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-27 Thread Eric Blake
On 06/27/2012 03:59 AM, Amos Kong wrote: >>> The interface looks like we have settled into something useful that >>> libvirt can live with. I will leave a more thorough review of the >>> series to those more familiar with qemu's internals. However, as long >>> as we are fine-tuning things, I hav

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-27 Thread Amos Kong
On 27/06/12 04:21, Luiz Capitulino wrote: On Wed, 20 Jun 2012 12:47:40 +0800 Amos Kong wrote: Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in monitor.c is the mapping of key name to keycode, Keys

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-27 Thread Amos Kong
On 27/06/12 04:22, Luiz Capitulino wrote: On Wed, 20 Jun 2012 06:53:40 -0600 Eric Blake wrote: On 06/19/2012 10:47 PM, Amos Kong wrote: Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in monitor.c

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-26 Thread Luiz Capitulino
On Wed, 20 Jun 2012 06:53:40 -0600 Eric Blake wrote: > On 06/19/2012 10:47 PM, Amos Kong wrote: > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > variables/functions in monitor.c, so reserve qmp_sendkey() > > to monitor.c > > > > key_defs[] in monitor.c is the mapping of key na

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-26 Thread Luiz Capitulino
On Wed, 20 Jun 2012 12:47:40 +0800 Amos Kong wrote: > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > variables/functions in monitor.c, so reserve qmp_sendkey() > to monitor.c > > key_defs[] in monitor.c is the mapping of key name to keycode, > Keys' order in the enmu and key_defs[

Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-20 Thread Eric Blake
On 06/19/2012 10:47 PM, Amos Kong wrote: > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > variables/functions in monitor.c, so reserve qmp_sendkey() > to monitor.c > > key_defs[] in monitor.c is the mapping of key name to keycode, > Keys' order in the enmu and key_defs[] is same. >

[Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey

2012-06-19 Thread Amos Kong
Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in monitor.c is the mapping of key name to keycode, Keys' order in the enmu and key_defs[] is same. Signed-off-by: Amos Kong --- hmp-commands.hx |2