Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Avi Kivity
On 09/19/2011 12:36 PM, Alexander Graf wrote: > >>8088-808f : macio >> 0006-0007 : macio-nvram >> 0002-00020fff : pmac-ide >> 00016000-00017fff : cuda >> 00013000-0001303f : escc-bar >> 8000-8fff : dbdma >> -0fff : heathrow

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Alexander Graf
On 19.09.2011, at 11:22, Avi Kivity wrote: > On 09/19/2011 12:15 PM, Alexander Graf wrote: >> On 17.09.2011, at 23:40, Blue Swirl wrote: >> >> > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >> >>> >> Sure :). So the pro

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Avi Kivity
On 09/19/2011 12:15 PM, Alexander Graf wrote: On 17.09.2011, at 23:40, Blue Swirl wrote: > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >>> Sure :). So the problem is that when emulating the G3 Beige machine in QEMU

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-19 Thread Alexander Graf
On 17.09.2011, at 23:40, Blue Swirl wrote: > On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: >> On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >>> Sure :). So the problem is that when emulating the G3 Beige machine in QEMU (default ppc32 target) we also add a PCI VGA adap

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-18 Thread Avi Kivity
On 09/18/2011 12:40 AM, Blue Swirl wrote: On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: > On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >> >> >Sure :). So the problem is that when emulating the G3 Beige machine in >> >QEMU (default ppc32 target) we also add a PCI VGA ada

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-17 Thread Blue Swirl
On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: > On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >> >> >  Sure :). So the problem is that when emulating the G3 Beige machine in >> >  QEMU (default ppc32 target) we also add a PCI VGA adapter. Apparently, >> >  on x86 that PCI VGA adapter

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: > Sure :). So the problem is that when emulating the G3 Beige machine in > QEMU (default ppc32 target) we also add a PCI VGA adapter. Apparently, > on x86 that PCI VGA adapter can map the special VGA regions to > somewhere, namely 0xa.

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Benjamin Herrenschmidt
> Sure :). So the problem is that when emulating the G3 Beige machine in > QEMU (default ppc32 target) we also add a PCI VGA adapter. Apparently, > on x86 that PCI VGA adapter can map the special VGA regions to > somewhere, namely 0xa. With the memory api overhaul, this also > slipped into the

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Alexander Graf
On 15.09.2011, at 03:24, Benjamin Herrenschmidt wrote: > On Wed, 2011-09-14 at 23:41 +0200, Alexander Graf wrote: >> On 14.09.2011, at 22:42, Richard Henderson wrote: >> >>> On 09/14/2011 01:35 PM, Alexander Graf wrote: >>> > Can you explain what the memory map looks like from the hardware

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/15/2011 04:24 AM, Benjamin Herrenschmidt wrote: On Wed, 2011-09-14 at 23:41 +0200, Alexander Graf wrote: > On 14.09.2011, at 22:42, Richard Henderson wrote: > > > On 09/14/2011 01:35 PM, Alexander Graf wrote: > > > >>> Can you explain what the memory map looks like from the hardware >

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-15 Thread Avi Kivity
On 09/14/2011 11:25 PM, Blue Swirl wrote: On Wed, Sep 14, 2011 at 8:15 PM, Avi Kivity wrote: > On 09/14/2011 11:06 PM, Blue Swirl wrote: >> >> On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivitywrote: >> >On 09/14/2011 11:27 AM, Alexander Graf wrote: >> >> >> >>On 14.09.2011, at 10:24,

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Benjamin Herrenschmidt
On Wed, 2011-09-14 at 23:41 +0200, Alexander Graf wrote: > On 14.09.2011, at 22:42, Richard Henderson wrote: > > > On 09/14/2011 01:35 PM, Alexander Graf wrote: > > > >>> Can you explain what the memory map looks like from the hardware > point of view? > >> > >> If you can tell me where to find

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Alexander Graf
On 14.09.2011, at 22:42, Richard Henderson wrote: > On 09/14/2011 01:35 PM, Alexander Graf wrote: > >>> Can you explain what the memory map looks like from the hardware point of >>> view? >> >> If you can tell me where to find out :). I seriously have zero experience in >> VGA mapping - and i

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Andreas Färber
Am 14.09.2011 um 22:42 schrieb Richard Henderson: On 09/14/2011 01:35 PM, Alexander Graf wrote: Can you explain what the memory map looks like from the hardware point of view? If you can tell me where to find out :). I seriously have zero experience in VGA mapping - and it sounds as if Bl

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Richard Henderson
On 09/14/2011 01:35 PM, Alexander Graf wrote: >> Can you explain what the memory map looks like from the hardware point of >> view? > > If you can tell me where to find out :). I seriously have zero experience in > VGA mapping - and it sounds as if Blue has a pretty good idea what's going on.

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Alexander Graf
Am 14.09.2011 um 22:16 schrieb Avi Kivity : > On 09/14/2011 11:14 PM, Alexander Graf wrote: >> >> (assuming I understood the problem correctly - not sure) >> > >> > I think you did. >> >> Well I don't completely, so would anybody who feels reasonably savvy in >> messing with the new memory ap

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Blue Swirl
On Wed, Sep 14, 2011 at 8:15 PM, Avi Kivity wrote: > On 09/14/2011 11:06 PM, Blue Swirl wrote: >> >> On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivity  wrote: >> >  On 09/14/2011 11:27 AM, Alexander Graf wrote: >> >> >> >>  On 14.09.2011, at 10:24, Jan Kiszka wrote: >> >> >> >>  >    On 2011-09-14 10:22

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/14/2011 11:14 PM, Alexander Graf wrote: >> (assuming I understood the problem correctly - not sure) > > I think you did. Well I don't completely, so would anybody who feels reasonably savvy in messing with the new memory api like to step up and implement this? :) Can you explain wha

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/14/2011 11:06 PM, Blue Swirl wrote: On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivity wrote: > On 09/14/2011 11:27 AM, Alexander Graf wrote: >> >> On 14.09.2011, at 10:24, Jan Kiszka wrote: >> >> >On 2011-09-14 10:22, Avi Kivity wrote: >> >>On 09/14/2011 11:20 AM, Jan Kiszka wrote: >

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Alexander Graf
On 14.09.2011, at 22:06, Blue Swirl wrote: > On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivity wrote: >> On 09/14/2011 11:27 AM, Alexander Graf wrote: >>> >>> On 14.09.2011, at 10:24, Jan Kiszka wrote: >>> On 2011-09-14 10:22, Avi Kivity wrote: > On 09/14/2011 11:20 AM, Jan Kiszka wrote:

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Blue Swirl
On Wed, Sep 14, 2011 at 8:35 AM, Avi Kivity wrote: > On 09/14/2011 11:27 AM, Alexander Graf wrote: >> >> On 14.09.2011, at 10:24, Jan Kiszka wrote: >> >> >  On 2011-09-14 10:22, Avi Kivity wrote: >> >>  On 09/14/2011 11:20 AM, Jan Kiszka wrote: >> >>  Anyway PCI supports the vga region a

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/14/2011 11:27 AM, Alexander Graf wrote: On 14.09.2011, at 10:24, Jan Kiszka wrote: > On 2011-09-14 10:22, Avi Kivity wrote: >> On 09/14/2011 11:20 AM, Jan Kiszka wrote: Anyway PCI supports the vga region at 0xa-0xc. Where is it supposed to be mapped? >>> >>> ..

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Jan Kiszka
On 2011-09-14 10:27, Alexander Graf wrote: > > On 14.09.2011, at 10:24, Jan Kiszka wrote: > >> On 2011-09-14 10:22, Avi Kivity wrote: >>> On 09/14/2011 11:20 AM, Jan Kiszka wrote: > > Anyway PCI supports the vga region at 0xa-0xc. Where is it > supposed to be mapped? >>>

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Alexander Graf
On 14.09.2011, at 10:24, Jan Kiszka wrote: > On 2011-09-14 10:22, Avi Kivity wrote: >> On 09/14/2011 11:20 AM, Jan Kiszka wrote: Anyway PCI supports the vga region at 0xa-0xc. Where is it supposed to be mapped? >>> >>> ...but not all PCI bridges make use of this feature

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Jan Kiszka
On 2011-09-14 10:22, Avi Kivity wrote: > On 09/14/2011 11:20 AM, Jan Kiszka wrote: >>> >>> Anyway PCI supports the vga region at 0xa-0xc. Where is it >>> supposed to be mapped? >> >> ...but not all PCI bridges make use of this feature / forward legacy >> requests. >> > > Then this shoul

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/14/2011 11:20 AM, Jan Kiszka wrote: > > Anyway PCI supports the vga region at 0xa-0xc. Where is it > supposed to be mapped? ...but not all PCI bridges make use of this feature / forward legacy requests. Then this should be fixed in the bridge? -- error compiling committee.c:

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Jan Kiszka
On 2011-09-14 10:17, Avi Kivity wrote: > On 09/14/2011 10:42 AM, Alexander Graf wrote: >> On 14.09.2011, at 09:11, Avi Kivity wrote: >> >>> On 09/13/2011 10:39 PM, Blue Swirl wrote: > > Here is the problem: Both the vram and the ISA range get mapped into > system address spac

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/14/2011 10:42 AM, Alexander Graf wrote: On 14.09.2011, at 09:11, Avi Kivity wrote: > On 09/13/2011 10:39 PM, Blue Swirl wrote: >> > >> > Here is the problem: Both the vram and the ISA range get mapped into >> > system address space, but the former eclipses the latter as it shows up

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Jan Kiszka
On 2011-09-14 09:42, Alexander Graf wrote: > > On 14.09.2011, at 09:11, Avi Kivity wrote: > >> On 09/13/2011 10:39 PM, Blue Swirl wrote: Here is the problem: Both the vram and the ISA range get mapped into system address space, but the former eclipses the latter as it shows up >>

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Alexander Graf
On 14.09.2011, at 09:11, Avi Kivity wrote: > On 09/13/2011 10:39 PM, Blue Swirl wrote: >> > >> > Here is the problem: Both the vram and the ISA range get mapped into >> > system address space, but the former eclipses the latter as it shows up >> > earlier in the list and has the same priority.

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-14 Thread Avi Kivity
On 09/13/2011 10:39 PM, Blue Swirl wrote: > > Here is the problem: Both the vram and the ISA range get mapped into > system address space, but the former eclipses the latter as it shows up > earlier in the list and has the same priority. This picture changes with > the chain-4 alias which has

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Blue Swirl
On Tue, Sep 13, 2011 at 11:34 AM, Jan Kiszka wrote: > On 2011-09-13 11:42, Alexander Graf wrote: >> >> On 13.09.2011, at 11:00, Jan Kiszka wrote: >> >>> On 2011-09-13 10:40, Alexander Graf wrote: Btw, it still tries to execute invalid code even with your patch. #if 0'ing out the memory

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Jan Kiszka
On 2011-09-13 11:42, Alexander Graf wrote: > > On 13.09.2011, at 11:00, Jan Kiszka wrote: > >> On 2011-09-13 10:40, Alexander Graf wrote: >>> Btw, it still tries to execute invalid code even with your patch. #if 0'ing >>> out the memory region updates at least get the guest booting for me. Btw,

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Andreas Färber
Am 13.09.2011 um 11:00 schrieb Jan Kiszka: On 2011-09-13 10:40, Alexander Graf wrote: Btw, it still tries to execute invalid code even with your patch. #if 0'ing out the memory region updates at least get the guest booting for me. Btw, to get it working you also need a patch for the interr

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Alexander Graf
On 13.09.2011, at 11:00, Jan Kiszka wrote: > On 2011-09-13 10:40, Alexander Graf wrote: >> Btw, it still tries to execute invalid code even with your patch. #if 0'ing >> out the memory region updates at least get the guest booting for me. Btw, to >> get it working you also need a patch for the

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Jan Kiszka
On 2011-09-13 10:40, Alexander Graf wrote: > Btw, it still tries to execute invalid code even with your patch. #if 0'ing > out the memory region updates at least get the guest booting for me. Btw, to > get it working you also need a patch for the interrupt controller (another > breakage thanks t

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Alexander Graf
On 13.09.2011, at 10:14, Jan Kiszka wrote: > On 2011-09-13 09:39, Alexander Graf wrote: >> >> On 12.09.2011, at 17:57, Jan Kiszka wrote: >> >>> On 2011-09-12 17:49, Jan Kiszka wrote: On 2011-09-12 17:45, Andreas Färber wrote: > Am 12.09.2011 17:33, schrieb Jan Kiszka: >> On 2011-09

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Andreas Färber
Am 13.09.2011 um 10:14 schrieb Jan Kiszka: On 2011-09-13 09:39, Alexander Graf wrote: (qemu) device_show #3 dev: VGA, id "#3", version 2 dev. version_id: 0002 config: 00 00 00 00 10 d1 cf 20 - 00 00 00 00 10 d1 d0 30 ... irq_state:

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Jan Kiszka
On 2011-09-13 09:39, Alexander Graf wrote: > > On 12.09.2011, at 17:57, Jan Kiszka wrote: > >> On 2011-09-12 17:49, Jan Kiszka wrote: >>> On 2011-09-12 17:45, Andreas Färber wrote: Am 12.09.2011 17:33, schrieb Jan Kiszka: > On 2011-09-12 17:20, Alexander Graf wrote: >> Jan Kiszka wro

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Avi Kivity
On 09/13/2011 10:54 AM, Alexander Graf wrote: >> >> Yeah, usually the ISA bus is behind an ISA-PCI bridge, so it should inherit the offset from its parent. Or do you mean something different? >> > > He means that isa_mem_base should go away; instead isa_address_space() should be a subregion a

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Alexander Graf
On 13.09.2011, at 09:51, Avi Kivity wrote: > On 09/13/2011 09:54 AM, Alexander Graf wrote: >> > >> > I had similar problems with sun4u, fixed with >> > f69539b14bdba7a5cd22e1f4bed439b476b17286. I think also here, PCI >> > should be given a memory range at 0x8000 and VGA should >> > automa

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Avi Kivity
On 09/13/2011 09:54 AM, Alexander Graf wrote: > > I had similar problems with sun4u, fixed with > f69539b14bdba7a5cd22e1f4bed439b476b17286. I think also here, PCI > should be given a memory range at 0x8000 and VGA should > automatically use that like. Yeah, usually the ISA bus is behind

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-13 Thread Alexander Graf
On 12.09.2011, at 17:57, Jan Kiszka wrote: > On 2011-09-12 17:49, Jan Kiszka wrote: >> On 2011-09-12 17:45, Andreas Färber wrote: >>> Am 12.09.2011 17:33, schrieb Jan Kiszka: On 2011-09-12 17:20, Alexander Graf wrote: > Jan Kiszka wrote: >> Most VGA memory access modes require MMIO h

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Alexander Graf
On 12.09.2011, at 22:21, Blue Swirl wrote: > On Mon, Sep 12, 2011 at 3:20 PM, Alexander Graf wrote: >> Jan Kiszka wrote: >>> Most VGA memory access modes require MMIO handling as they demand weird >>> logic to get a byte from or into the video RAM. However, there is one >>> exception: chain 4 mo

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 3:20 PM, Alexander Graf wrote: > Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writing. This

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:49, Jan Kiszka wrote: > On 2011-09-12 17:45, Andreas Färber wrote: >> Am 12.09.2011 17:33, schrieb Jan Kiszka: >>> On 2011-09-12 17:20, Alexander Graf wrote: Jan Kiszka wrote: > Most VGA memory access modes require MMIO handling as they demand weird > logic to get a by

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:45, Andreas Färber wrote: > Am 12.09.2011 17:33, schrieb Jan Kiszka: >> On 2011-09-12 17:20, Alexander Graf wrote: >>> Jan Kiszka wrote: Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Andreas Färber
Am 12.09.2011 17:33, schrieb Jan Kiszka: > On 2011-09-12 17:20, Alexander Graf wrote: >> Jan Kiszka wrote: >>> Most VGA memory access modes require MMIO handling as they demand weird >>> logic to get a byte from or into the video RAM. However, there is one >>> exception: chain 4 mode with all memor

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:20, Alexander Graf wrote: > Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writing. This >> mode actu

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Alexander Graf
Jan Kiszka wrote: > Most VGA memory access modes require MMIO handling as they demand weird > logic to get a byte from or into the video RAM. However, there is one > exception: chain 4 mode with all memory planes enabled for writing. This > mode actually allows lineary mapping, which can then be co

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 13:19, Avi Kivity wrote: > On 08/25/2011 01:51 PM, Jan Kiszka wrote: >>> >>> Plain F15 is slow. SR2 = SR4 = 0. >> >> So it's not using chain4 mode. Can you check what mode the adapter is >> actually in and how VRAM is accessed? Likely, there is nothing we can do >> about it. /me jus

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 01:51 PM, Jan Kiszka wrote: > > Plain F15 is slow. SR2 = SR4 = 0. So it's not using chain4 mode. Can you check what mode the adapter is actually in and how VRAM is accessed? Likely, there is nothing we can do about it. /me just wonders what makes F15 grub behave differently from

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 12:45, Avi Kivity wrote: > On 08/25/2011 12:21 PM, Jan Kiszka wrote: >>> >>> Still slow. I tried an old F11 image I had lying around, and -snapshot >>> /dev/sda, but this laptop was installed many years ago. I'll download >>> some more images and try. >> >> You may also want to i

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 12:21 PM, Jan Kiszka wrote: > > Still slow. I tried an old F11 image I had lying around, and -snapshot > /dev/sda, but this laptop was installed many years ago. I'll download > some more images and try. You may also want to instrument vga_update_memory_access if some requireme

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 11:16, Avi Kivity wrote: > On 08/25/2011 12:07 PM, Jan Kiszka wrote: >>> >>> On which version of grub does this work? This isn't having any effect >>> on my Fedora grub. >> >> It's both grub1 (0.97) in graphical mode as used by OpenSUSE 11.4 and >> grub2 (1.99-rc1) of Ubuntu 1

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/25/2011 12:07 PM, Jan Kiszka wrote: >> > > On which version of grub does this work? This isn't having any effect > on my Fedora grub. It's both grub1 (0.97) in graphical mode as used by OpenSUSE 11.4 and grub2 (1.99-rc1) of Ubuntu 11.04. Is Fedora's grub still slow or was it already fa

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Jan Kiszka
On 2011-08-25 09:19, Avi Kivity wrote: > On 08/22/2011 08:12 PM, Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writin

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-25 Thread Avi Kivity
On 08/22/2011 08:12 PM, Jan Kiszka wrote: Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping, wh

[Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-08-22 Thread Jan Kiszka
Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping, which can then be combined with dirty logging