Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Wed, Jun 13, 2018 at 02:53:37PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 10:47:45AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > > People have been trying to add qom-get etc for quite a while (I

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 10:47:45AM -0300, Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: > [...] > > > > People have been trying to add qom-get etc for quite a while (I tried a > > > > couple of years ago); it gets stuck in type display issues.

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: [...] > > > People have been trying to add qom-get etc for quite a while (I tried a > > > couple of years ago); it gets stuck in type display issues. I've not > > > directly seen a need for those other variants, but qom-get

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 09:00:20AM +0200, Markus Armbruster wrote: > Igor Mammedov writes: > > > On Mon, 11 Jun 2018 15:40:16 -0300 > > Eduardo Habkost wrote: > > > >> On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > >> > * Eduardo, why does "info numa" have no QMP

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> > Now let's review the three commands: > >> > > >> > * Gerd, why does "info usbhost" have no QMP equivalent? > > > > Works only when running qemu directly, in the libvirt sandbox qemu > > hasn't the

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > Now let's review the three commands: >> > >> > * Gerd, why does "info usbhost" have no QMP equivalent? > > Works only when running qemu directly, in the libvirt sandbox qemu > hasn't the permissions needed to scan the host usb bus so that would be > rather

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Allow a bunch of the info commands to be used in

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 11:33:42PM +0200, Igor Mammedov wrote: > On Mon, 11 Jun 2018 15:40:16 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > > > * Eduardo, why does "info numa" have no QMP equivalent? > > > > Nobody ever asked for one,

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Markus Armbruster
Igor Mammedov writes: > On Mon, 11 Jun 2018 15:40:16 -0300 > Eduardo Habkost wrote: > >> On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: >> > * Eduardo, why does "info numa" have no QMP equivalent? >> >> Nobody ever asked for one, which seems to qualify as "only for >> human

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Allow a bunch of the info commands to be used in preconfig. >> > >> > version, chardev, name, uuid,memdev, iothreads >>

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-11 Thread Gerd Hoffmann
Hi, > > Now let's review the three commands: > > > > * Gerd, why does "info usbhost" have no QMP equivalent? Works only when running qemu directly, in the libvirt sandbox qemu hasn't the permissions needed to scan the host usb bus so that would be rather pointless ... cheers, Gerd

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-11 Thread Igor Mammedov
On Mon, 11 Jun 2018 15:40:16 -0300 Eduardo Habkost wrote: > On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > > * Eduardo, why does "info numa" have no QMP equivalent? > > Nobody ever asked for one, which seems to qualify as "only for > human users". > > Should we add an

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-11 Thread Eduardo Habkost
On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > * Eduardo, why does "info numa" have no QMP equivalent? Nobody ever asked for one, which seems to qualify as "only for human users". Should we add an equivalent QMP command even if we don't expect anybody to use it? --

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-11 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Allow a bunch of the info commands to be used in preconfig. > > > > version, chardev, name, uuid,memdev, iothreads > > Were enabled in QMP in the previous patch

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-11 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > > version, chardev, name, uuid,memdev, iothreads > Were enabled in QMP in the previous patch from Igor Yes, these are okay together with PATCH 4. >

[Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow a bunch of the info commands to be used in preconfig. version, chardev, name, uuid,memdev, iothreads Were enabled in QMP in the previous patch from Igor status, hotpluggable_cpus Was enabled in the original allow-preconfig series history is HMP