Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-07 Thread Mao Zhongyi
Hi, Markus On 06/07/2017 03:05 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Eduardo On 06/06/2017 10:52 PM, Eduardo Habkost wrote: On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. T

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-07 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Eduardo > > On 06/06/2017 10:52 PM, Eduardo Habkost wrote: >> On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: >>> Add Error argument for pci_add_capability() to leverage the errp >>> to pass info on errors. This way is helpful for its callers to >>> make a b

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-06 Thread Mao Zhongyi
Hi, Eduardo On 06/06/2017 10:52 PM, Eduardo Habkost wrote: On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. This way is helpful for its callers to make a better error handling when moving to 're

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-06 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: >> Add Error argument for pci_add_capability() to leverage the errp >> to pass info on errors. This way is helpful for its callers to >> make a better error handling when moving to 'realize'. >> >> Cc: pbonz..

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-06 Thread Eduardo Habkost
On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: > Add Error argument for pci_add_capability() to leverage the errp > to pass info on errors. This way is helpful for its callers to > make a better error handling when moving to 'realize'. > > Cc: pbonz...@redhat.com > Cc: r...@twiddle.n

[Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-06 Thread Mao Zhongyi
Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. This way is helpful for its callers to make a better error handling when moving to 'realize'. Cc: pbonz...@redhat.com Cc: r...@twiddle.net Cc: ehabk...@redhat.com Cc: m...@redhat.com CC: dmi...@daynix.com Cc: