Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-06 Thread Luiz Capitulino
On Mon, 05 Mar 2012 20:44:39 +0100 Paolo Bonzini wrote: > Il 05/03/2012 19:55, Eric Blake ha scritto: > > Right now, libvirt has an API virDomainSnapshotCreateXML with a flag > > VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode > > operand. Am I guaranteed that if I pass a

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 20:44, Paolo Bonzini ha scritto: > Il 05/03/2012 19:55, Eric Blake ha scritto: >> Right now, libvirt has an API virDomainSnapshotCreateXML with a flag >> VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode >> operand. Am I guaranteed that if I pass a 'mode' argume

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 19:55, Eric Blake ha scritto: > Right now, libvirt has an API virDomainSnapshotCreateXML with a flag > VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode > operand. Am I guaranteed that if I pass a 'mode' argument of 'existing' > to an older qemu that lacked mode

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Eric Blake
On 03/05/2012 10:33 AM, Paolo Bonzini wrote: > Simplify the blockdev-snapshot-sync code and gain failsafe operation > by turning it into a wrapper around the new transaction command. A new > option is also added matching "mode". > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 81 +

[Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Simplify the blockdev-snapshot-sync code and gain failsafe operation by turning it into a wrapper around the new transaction command. A new option is also added matching "mode". Signed-off-by: Paolo Bonzini --- blockdev.c | 81 - hmp-c